-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Add support for Packages API #2076
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @Cyb3r-Jak3 !
This is off to a great start. I have to run now, but will continue my review later.
This should give you a good idea of what I'm looking for.
Thank you, @Cyb3r-Jak3 , but I'm going to hold off on a complete review until all unit tests are passing.
Please see our CONTRIBUTING.md guide to show you how to run the tests before pushing changes. Thanks. |
@gmlewis, sorry about that. All good now. |
Codecov Report
@@ Coverage Diff @@
## master #2076 +/- ##
==========================================
- Coverage 97.77% 97.77% -0.01%
==========================================
Files 109 111 +2
Lines 9720 9932 +212
==========================================
+ Hits 9504 9711 +207
- Misses 150 154 +4
- Partials 66 67 +1
Continue to review full report at Codecov.
|
I'll commit this one... can you please address the other ones to match the testing pattern?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @Cyb3r-Jak3 !
This looks great! I really appreciate your patience with me and my reviews.
LGTM.
Awaiting second LGTM before merging.
@wesleimp Nudge |
@Parker77 - if you have time to do a code review, that would be greatly appreciated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Thank you, @Parker77 ! |
Adds support for Packages API through expansion of Users and Organization Services.
Would resolve #2075