Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add pagination fields to code scanning #2100

Merged
merged 4 commits into from
Sep 20, 2021
Merged

Add pagination fields to code scanning #2100

merged 4 commits into from
Sep 20, 2021

Conversation

ganeshkumarsv
Copy link
Contributor

No description provided.

@google-cla google-cla bot added the cla: yes Indication that the PR author has signed a Google Contributor License Agreement. label Sep 19, 2021
@codecov
Copy link

codecov bot commented Sep 19, 2021 •
edited

Codecov Report

Merging #2100 (31bfc67) into master (bd8dd52) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2100   +/-   ##
=======================================
  Coverage   97.77%   97.77%           
=======================================
  Files         109      109           
  Lines        9724     9724           
=======================================
  Hits         9508     9508           
  Misses        150      150           
  Partials       66       66
Impacted Files Coverage Δ
github/code-scanning.go 100.00% <ø> (ø)
github/event_types.go 100.00% <0.00%> (ø)
github/actions_workflow_runs.go 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd8dd52...31bfc67. Read the comment docs.

@ganeshkumarsv ganeshkumarsv marked this pull request as draft September 19, 2021 20:01
gmlewis
gmlewis reviewed Sep 19, 2021
View reviewed changes
github/code-scanning.go Outdated Show resolved Hide resolved
@gmlewis gmlewis changed the title adding pagination fields to code scanning Add pagination fields to code scanning Sep 19, 2021
@ganeshkumarsv ganeshkumarsv marked this pull request as ready for review September 19, 2021 22:43
@ganeshkumarsv ganeshkumarsv force-pushed the add_pagination_params_to_codescanning branch from bb25e8f to 4f19006 Compare September 19, 2021 22:47
@ganeshkumarsv @gmlewis
Update github/code-scanning.go
31bfc67 
Co-authored-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
gmlewis
gmlewis approved these changes Sep 20, 2021
View reviewed changes
Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @ganeshkumarsv !
LGTM.
Merging.

@gmlewis gmlewis merged commit dfcb780 into google:master Sep 20, 2021
@ganeshkumarsv
Copy link
Contributor Author

@gmlewis Can we have a new release version?

@gmlewis
Copy link
Collaborator

gmlewis commented Sep 23, 2021

@ganeshkumarsv - https://github.com/google/go-github/releases/tag/v39.1.0 now contains this change.

@ganeshkumarsv
Copy link
Contributor Author

Thank you! 🙇‍♂️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmlewis gmlewis gmlewis approved these changes

Assignees
No one assigned
Labels
cla: yes Indication that the PR author has signed a Google Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ganeshkumarsv @gmlewis