-
Notifications
You must be signed in to change notification settings - Fork 2.1k
feat: generate release notes support #2114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Carlos A Becker <caarlos0@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #2114 +/- ##
=======================================
Coverage 97.78% 97.78%
=======================================
Files 112 112
Lines 9956 9970 +14
=======================================
+ Hits 9735 9749 +14
Misses 154 154
Partials 67 67
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @caarlos0 !
Just a few minor tweaks, please.
Also, to clarify, you can drop the omitempty
and the pointer to a field if you know they are absolutely mandatory.
Signed-off-by: Carlos A Becker <caarlos0@gmail.com>
Signed-off-by: Carlos A Becker <caarlos0@gmail.com>
Thanks for the review @gmlewis! Just fixed the based on this tweet. |
Signed-off-by: Carlos A Becker <caarlos0@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @caarlos0 !
LGTM.
Awaiting second LGTM (from any other contributor to this repo) before merging.
can someone else review/merge this? |
@Parker77 - do you have time to review this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Thank you, @Parker77! |
supports the new feature github announced today: generate release notes (link)
while there are no official docs yet, one of the product managers posted screenshots of it on twitter: https://twitter.com/MylesBorins/status/1445102641214861318
This implements both the new
/releases/generate-notes
endpoint and the newgenerate_release_notes
release option.