Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runnerID and runnerGroupID are int64, not string #2127

Merged
merged 2 commits into from Oct 18, 2021

Conversation

sfunkhouser
Copy link
Contributor

When running this before the change, results that included runnerID or runnerGroupID could not be parsed. This PR changes the type for both from string -> int64

@google-cla
Copy link

google-cla bot commented Oct 18, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no label Oct 18, 2021
@gmlewis
Copy link
Collaborator

gmlewis commented Oct 18, 2021

Thank you, @sfunkhouser - can you find any official GitHub docs that show these values as integers? I'm curious because I thought the original implementation came from an example where they were strings... but now I'm having troubles finding the examples.

Also, if you could please fix the CLA and the unit tests, we can move forward with this PR.

@gmlewis gmlewis added the Breaking API Change PR will require a bump to the major version num in next release. Look here to see the change(s). label Oct 18, 2021
@google-cla
Copy link

google-cla bot commented Oct 18, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@sfunkhouser
Copy link
Contributor Author

@googlebot I signed it!

@google-cla google-cla bot added cla: yes Indication that the PR author has signed a Google Contributor License Agreement. and removed cla: no labels Oct 18, 2021
@codecov
Copy link

codecov bot commented Oct 18, 2021

Codecov Report

Merging #2127 (fcec112) into master (d1858a3) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2127   +/-   ##
=======================================
  Coverage   97.78%   97.78%           
=======================================
  Files         112      112           
  Lines        9970     9970           
=======================================
  Hits         9749     9749           
  Misses        154      154           
  Partials       67       67           
Impacted Files Coverage Δ
github/orgs_audit_log.go 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d1858a3...fcec112. Read the comment docs.

@sfunkhouser
Copy link
Contributor Author

Thank you, @sfunkhouser - can you find any official GitHub docs that show these values as integers? I'm curious because I thought the original implementation came from an example where they were strings... but now I'm having troubles finding the examples.

Also, if you could please fix the CLA and the unit tests, we can move forward with this PR.

Looking for the docs, I've only found the runner docs, which reference them as integers (https://docs.github.com/en/enterprise-server@2.22/rest/reference/enterprise-admin#add-a-self-hosted-runner-to-a-group-for-an-enterprise) and when I ran through the audit logs I got an unmarshal error but let me see if I can find some more concrete documentation on this. I'll follow-up tomorrow.

@gmlewis
Copy link
Collaborator

gmlewis commented Oct 18, 2021

Thank you, @sfunkhouser - can you find any official GitHub docs that show these values as integers? I'm curious because I thought the original implementation came from an example where they were strings... but now I'm having troubles finding the examples.
Also, if you could please fix the CLA and the unit tests, we can move forward with this PR.

Looking for the docs, I've only found the runner docs, which reference them as integers (https://docs.github.com/en/enterprise-server@2.22/rest/reference/enterprise-admin#add-a-self-hosted-runner-to-a-group-for-an-enterprise) and when I ran through the audit logs I got an unmarshal error but let me see if I can find some more concrete documentation on this. I'll follow-up tomorrow.

Ah, yes! There it is. Thank you for the pointer! So I'm not sure what happened, but this should fix it. Thanks again, @sfunkhouser !

Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @sfunkhouser !
LGTM.
Merging.

@gmlewis gmlewis merged commit 72ec8bb into google:master Oct 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Breaking API Change PR will require a bump to the major version num in next release. Look here to see the change(s). cla: yes Indication that the PR author has signed a Google Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants