audit log query options should use url tag #2128
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the query option params for the audit log I noticed the filters were not working, for example, when setting:
The results returned contained other activites besides the listed actor. Upon further investigation, I noticed the query string being sent was:
Although, I don't understand why these are case sensitive, when testing with
The expected results are returned.
Looking at the other
...Options
structs in this repo I saw that those all use theurl
tag instead ofjson
. Switching to this allowed for the correct string to be used in the the query string and resulting data back was correct.