Support Github Advanced Security repository settings #2133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gmlewis let me know if you'd like me to add any other tests other than the generated ones. |
asvoboda
force-pushed
the
advc-security
branch
from
aeb8c43
to
9b18240
Compare
|
Please try not to use force-push in this repo's PRs because it makes it more challenging for reviewers to see what changed since their last code review. |
Codecov Report
@@ Coverage Diff @@
## master #2133 +/- ##
=======================================
Coverage 97.78% 97.78%
=======================================
Files 112 112
Lines 9970 9976 +6
=======================================
+ Hits 9749 9755 +6
Misses 154 154
Partials 67 67
Continue to review full report at Codecov.
|
asvoboda
commented
Oct 19, 2021
| @@ -360,7 +360,7 @@ func TestRepositoriesService_Get(t *testing.T) { | |||
| mux.HandleFunc("/repos/o/r", func(w http.ResponseWriter, r *http.Request) { | |||
| testMethod(t, r, "GET") | |||
| testHeader(t, r, "Accept", strings.Join(wantAcceptHeaders, ", ")) | |||
| fmt.Fprint(w, `{"id":1,"name":"n","description":"d","owner":{"login":"l"},"license":{"key":"mit"}}`) | |||
| fmt.Fprint(w, `{"id":1,"name":"n","description":"d","owner":{"login":"l"},"license":{"key":"mit"},"security_and_analysis":{"advanced_security":{"status":"enabled"},"secret_scanning":{"status":"enabled"}}}`) | |||
There was a problem hiding this comment.
Let me know if there is a better place for this, or if you'd like a separate test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds new fields from Advanced Security, as documented in https://docs.github.com/en/rest/reference/repos#update-a-repository and https://docs.github.com/en/get-started/learning-about-github/about-github-advanced-security
Fixes #2132