Skip to content

Upload Code Scanning Sarif results to GitHub #2165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Nov 8, 2021
Merged

Upload Code Scanning Sarif results to GitHub #2165

merged 14 commits into from
Nov 8, 2021
+224 −0

Conversation

ganeshkumarsv
Copy link
Contributor

@ganeshkumarsv ganeshkumarsv commented Oct 28, 2021 •
edited
Loading

Add a method to upload Code Scanning Sarif results to GitHub

ganeshkumarsv and others added 5 commits October 25, 2021 20:07
@ganeshkumarsv
Add a method to upload Sarif results to Github

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
dbf1d70 
Add a method to upload Code Scanning Sarif results to Github
@ganeshkumarsv
adding sarif struct to push the response

Verified

This commit was signed with the committer’s verified signature.
ganeshkumarsv
GPG key ID: BA3296920EA2A500
Verified
Learn about vigilant mode
c743d4c
@ganeshkumarsv
fix upload sarif

Verified

This commit was signed with the committer’s verified signature.
ganeshkumarsv
GPG key ID: BA3296920EA2A500
Verified
Learn about vigilant mode
1496951
@ganeshkumarsv
adding docs for uploading sarif

Verified

This commit was signed with the committer’s verified signature.
ganeshkumarsv
GPG key ID: BA3296920EA2A500
Verified
Learn about vigilant mode
3aec3e5
@ganeshkumarsv
fix variables for uploading sarif

Verified

This commit was signed with the committer’s verified signature.
ganeshkumarsv
GPG key ID: BA3296920EA2A500
Verified
Learn about vigilant mode
05dc42e
@google-cla google-cla bot added the cla: yes Indication that the PR author has signed a Google Contributor License Agreement. label Oct 28, 2021
@ganeshkumarsv
adding accessors for upload sarif method

Verified

This commit was signed with the committer’s verified signature.
ganeshkumarsv
GPG key ID: BA3296920EA2A500
Verified
Learn about vigilant mode
d051ca3
@codecov
Copy link

codecov bot commented Oct 28, 2021 •
edited
Loading

Codecov Report

Merging #2165 (504ad44) into master (d9d58a2) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2165   +/-   ##
=======================================
  Coverage   97.78%   97.78%           
=======================================
  Files         112      112           
  Lines        9976     9989   +13     
=======================================
+ Hits         9755     9768   +13     
  Misses        154      154           
  Partials       67       67
Impacted Files Coverage Δ
github/code-scanning.go 100.00% <100.00%> (ø)
github/github.go 97.58% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d9d58a2...504ad44. Read the comment docs.

@ganeshkumarsv
adding test case for Upload Sarif

Verified

This commit was signed with the committer’s verified signature.
ganeshkumarsv
GPG key ID: BA3296920EA2A500
Verified
Learn about vigilant mode
73eb8f3
gmlewis
gmlewis requested changes Oct 28, 2021
View reviewed changes
Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We recently switched from reflect to "github.com/google/go-cmp/cmp".
Please do the same here.

@ganeshkumarsv
replace reflect with cmp

Verified

This commit was signed with the committer’s verified signature.
ganeshkumarsv
GPG key ID: BA3296920EA2A500
Verified
Learn about vigilant mode
8fe1023
@ganeshkumarsv ganeshkumarsv requested a review from gmlewis October 30, 2021 11:17
gmlewis
gmlewis requested changes Oct 30, 2021
View reviewed changes
Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @ganeshkumarsv , but as written, this code is not going to work.

Once you have addressed all my comments, please actually test out your code using the GitHub API and verify that it works correctly.

@ganeshkumarsv
addressing code review comments

Verified

This commit was signed with the committer’s verified signature.
ganeshkumarsv
GPG key ID: BA3296920EA2A500
Verified
Learn about vigilant mode
94a6a58
@ganeshkumarsv
address code review comments

Verified

This commit was signed with the committer’s verified signature.
ganeshkumarsv
GPG key ID: BA3296920EA2A500
Verified
Learn about vigilant mode
afd8800
gmlewis
gmlewis requested changes Nov 2, 2021
View reviewed changes
@ganeshkumarsv
add go-doc style and address review comments

Verified

This commit was signed with the committer’s verified signature.
ganeshkumarsv
GPG key ID: BA3296920EA2A500
Verified
Learn about vigilant mode
f7288a7
@ganeshkumarsv
go fmt

Verified

This commit was signed with the committer’s verified signature.
ganeshkumarsv
GPG key ID: BA3296920EA2A500
Verified
Learn about vigilant mode
f642f4e
@ganeshkumarsv
change accessors after modifying the structs

Verified

This commit was signed with the committer’s verified signature.
ganeshkumarsv
GPG key ID: BA3296920EA2A500
Verified
Learn about vigilant mode
86e6e4d
@ganeshkumarsv ganeshkumarsv requested a review from gmlewis November 2, 2021 17:23
@ganeshkumarsv
Copy link
Contributor Author

@gmlewis Thanks for all the review comments! I think I addressed all of them and tested. Please let me know if anything else needs to be changed.

gmlewis
gmlewis requested changes Nov 2, 2021
View reviewed changes
@ganeshkumarsv
address review comments

Verified

This commit was signed with the committer’s verified signature.
ganeshkumarsv
GPG key ID: BA3296920EA2A500
Verified
Learn about vigilant mode
504ad44
@ganeshkumarsv ganeshkumarsv requested a review from gmlewis November 3, 2021 01:19
@ganeshkumarsv
Copy link
Contributor Author

addressed the remaining comments.

gmlewis
gmlewis approved these changes Nov 3, 2021
View reviewed changes
Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @ganeshkumarsv !
LGTM.

Awaiting second LGTM (from any other go-github contributor) before merging.

@gmlewis gmlewis requested a review from wesleimp November 3, 2021 13:43
@ganeshkumarsv
Copy link
Contributor Author

@wesleimp @gmlewis
gentle bump on the PR 🙏

@viveknathani
Copy link
Contributor

Thank you, @ganeshkumarsv ! LGTM.

Awaiting second LGTM (from any other go-github contributor) before merging.

LGTM!

@gmlewis
Copy link
Collaborator

gmlewis commented Nov 8, 2021

Thank you, @viveknathani !
Merging.

@gmlewis gmlewis merged commit fdb62f6 into google:master Nov 8, 2021
@ganeshkumarsv
Copy link
Contributor Author

@gmlewis can we have a new release for go-github? 🙇‍♂️

@gmlewis
Copy link
Collaborator

gmlewis commented Nov 8, 2021

@gmlewis can we have a new release for go-github? 🙇‍♂️

Yes, I'll work on that today.

@ganeshkumarsv
Copy link
Contributor Author

Thank you! 😊 🙇‍♂️

@gmlewis gmlewis mentioned this pull request Nov 8, 2021
Merged
@gmlewis
Copy link
Collaborator

gmlewis commented Nov 8, 2021

@ganeshkumarsv - this has been released into v40: https://github.com/google/go-github/releases/tag/v40.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmlewis gmlewis

@viveknathani viveknathani

@wesleimp wesleimp

Assignees
No one assigned
Labels
cla: yes Indication that the PR author has signed a Google Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ganeshkumarsv @viveknathani @gmlewis