Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new RemoveMilestone method on IssuesService #2195

Merged
merged 6 commits into from Nov 4, 2021
Merged

Add new RemoveMilestone method on IssuesService #2195

merged 6 commits into from Nov 4, 2021

Conversation

AGMETEOR
Copy link
Contributor

@AGMETEOR AGMETEOR commented Nov 2, 2021

Fixes #236

@google-cla google-cla bot added the cla: yes Indication that the PR author has signed a Google Contributor License Agreement. label Nov 2, 2021
@AGMETEOR
Copy link
Contributor Author

AGMETEOR commented Nov 2, 2021

Hi @gmlewis and @cpanato . Mind taking a look at my PR?

@codecov
Copy link

codecov bot commented Nov 2, 2021 •
edited

Codecov Report

Merging #2195 (7ce86cd) into master (f99e304) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2195   +/-   ##
=======================================
  Coverage   97.78%   97.78%           
=======================================
  Files         112      112           
  Lines        9976     9990   +14     
=======================================
+ Hits         9755     9769   +14     
  Misses        154      154           
  Partials       67       67
Impacted Files Coverage Δ
github/issues.go 97.41% <100.00%> (+0.35%) ⬆️
github/github.go 97.58% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f99e304...7ce86cd. Read the comment docs.

@gmlewis gmlewis changed the title Add new method, RemoveMilesone on IssuesService Add new method, RemoveMilestone on IssuesService Nov 2, 2021
gmlewis
gmlewis requested changes Nov 2, 2021
View reviewed changes
Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @AGMETEOR !
Just a couple minor tweaks, please, then we'll be ready for a second LGTM before merging.

github/issues.go Outdated Show resolved Hide resolved
github/issues.go Outdated Show resolved Hide resolved
github/issues.go Outdated Show resolved Hide resolved
@gmlewis gmlewis changed the title Add new method, RemoveMilestone on IssuesService Add new RemoveMilestone method on IssuesService Nov 2, 2021
cpanato
cpanato reviewed Nov 3, 2021
View reviewed changes
Copy link
Contributor

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'm not a maintainer of this project, but Glenn already did a great job reviewing this pr

besides that LGTM after the comments being addressed

thanks for working on this!

AGMETEOR and others added 3 commits November 3, 2021 22:14
@AGMETEOR @gmlewis
Update github/issues.go
996572d 
Co-authored-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
@AGMETEOR @gmlewis
Update github/issues.go
9d83458 
Co-authored-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
@AGMETEOR
use explicit type
33696c9
@AGMETEOR AGMETEOR requested a review from gmlewis November 3, 2021 19:20
@AGMETEOR
Copy link
Contributor Author

AGMETEOR commented Nov 3, 2021

Hi @gmlewis . I have made updates. Kindly requesting for another review.

gmlewis
gmlewis requested changes Nov 3, 2021
View reviewed changes
github/issues.go Outdated Show resolved Hide resolved
@AGMETEOR @gmlewis
Update github/issues.go
7ce86cd 
Co-authored-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
gmlewis
gmlewis approved these changes Nov 4, 2021
View reviewed changes
Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @AGMETEOR !
LGTM.

Merging based upon @cpanato additional approval.
Thank you, @cpanato !

@gmlewis gmlewis merged commit 07267ab into google:master Nov 4, 2021
@cpanato
Copy link
Contributor

cpanato commented Nov 4, 2021

/lgtm

@gmlewis gmlewis mentioned this pull request Nov 8, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpanato cpanato cpanato left review comments

@gmlewis gmlewis gmlewis approved these changes

Assignees
No one assigned
Labels
cla: yes Indication that the PR author has signed a Google Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

IssuesService.Edit cannot clear an issue's milestone
3 participants
@AGMETEOR @cpanato @gmlewis