Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for creating reaction for a release #2196

Merged
merged 2 commits into from Nov 8, 2021

Conversation

viveknathani
Copy link
Contributor

closes #2194

@google-cla google-cla bot added the cla: yes Indication that the PR author has signed a Google Contributor License Agreement. label Nov 3, 2021
@codecov
Copy link

codecov bot commented Nov 3, 2021

Codecov Report

Merging #2196 (87dbde1) into master (a9c254e) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2196   +/-   ##
=======================================
  Coverage   97.78%   97.78%           
=======================================
  Files         112      112           
  Lines        9976     9992   +16     
=======================================
+ Hits         9755     9771   +16     
  Misses        154      154           
  Partials       67       67           
Impacted Files Coverage Δ
github/reactions.go 97.84% <100.00%> (+0.13%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a9c254e...87dbde1. Read the comment docs.

Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @viveknathani !
LGTM.

Awaiting second LGTM (from any other go-github contributor) before merging.

@gmlewis gmlewis requested a review from wesleimp November 3, 2021 13:48
@viveknathani
Copy link
Contributor Author

@gmlewis It seems like the requested reviewer has not been active in this repository for quite some time (as per the pending PRs). Can we get somebody else to do the review if that is okay?

@gmlewis
Copy link
Collaborator

gmlewis commented Nov 6, 2021

@gmlewis It seems like the requested reviewer has not been active in this repository for quite some time (as per the pending PRs). Can we get somebody else to do the review if that is okay?

Hi @viveknathani .

Any contributor to this repo is welcome to review and approve PRs, but there are only a small number of people on the official "Reviewers" list that can be requested and I unfortunately can not modify that list like I could in the past.

@viveknathani
Copy link
Contributor Author

viveknathani commented Nov 6, 2021

All right @gmlewis. @ganeshkumarsv, @devfd, @sushmitaw, @AGMETEOR could you do the code review over here since you have been a recent contributor to this repository?

@viveknathani
Copy link
Contributor Author

@gmlewis Is there any other way we can move forward from here? Getting a second voluntary reviewer is not working out...

@AGMETEOR
Copy link
Contributor

AGMETEOR commented Nov 8, 2021

All right @gmlewis. @ganeshkumarsv, @devfd, @sushmitaw, @AGMETEOR could you do the code review over here since you have been a recent contributor to this repository?

Sorry for any delays. I approve the changes.

@viveknathani
Copy link
Contributor Author

@gmlewis Is there any other way we can move forward from here? Getting a second voluntary reviewer is not working out...
@gmlewis looks like we got one! Thanks @AGMETEOR!

@gmlewis
Copy link
Collaborator

gmlewis commented Nov 8, 2021

Thank you, @AGMETEOR !
Merging.

@gmlewis gmlewis merged commit e458912 into google:master Nov 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Indication that the PR author has signed a Google Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for creating reaction for a release
3 participants