-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Add missing fields to Timeline #2197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@googlebot I signed it! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @devfd .
Please make sure to run go generate ./...
and push (not force-push) the changes to the PR.
See CONTRIBUTING.md for more details.
my bad, thanks @gmlewis |
Codecov Report
@@ Coverage Diff @@
## master #2197 +/- ##
=======================================
Coverage 97.79% 97.79%
=======================================
Files 112 112
Lines 10003 10003
=======================================
Hits 9782 9782
Misses 154 154
Partials 67 67
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @devfd !
LGTM.
Merging.
No description provided.