Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing attribute job_runs in WorkflowRunBill #2206

Merged
merged 2 commits into from Nov 18, 2021

Conversation

marcelocarlos
Copy link
Contributor

What type of PR is this?

Update WorkflowRunBill to include a missing attribute

What this PR does / why we need it

Brings the implementation inline with the expected API response (docs here).

WorkflowRunBill current implementation is missing the JobRuns (job_runs) attribute. This is important when calculating the actual cost and time spent in a given workflow run as the total_ms doesn't include the rounding ups or multipliers that GitHub applied to each job run.

@google-cla google-cla bot added the cla: yes Indication that the PR author has signed a Google Contributor License Agreement. label Nov 18, 2021
@codecov
Copy link

codecov bot commented Nov 18, 2021

Codecov Report

Merging #2206 (b046070) into master (a4ce810) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2206   +/-   ##
=======================================
  Coverage   97.79%   97.79%           
=======================================
  Files         112      112           
  Lines       10036    10036           
=======================================
  Hits         9815     9815           
  Misses        154      154           
  Partials       67       67           
Impacted Files Coverage Δ
github/actions_workflow_runs.go 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a4ce810...b046070. Read the comment docs.

Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @marcelocarlos !
LGTM.
Merging.

@gmlewis gmlewis merged commit b26fa8f into google:master Nov 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Indication that the PR author has signed a Google Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants