Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add BranchProtectionRuleEvent Installation field #2216

Merged
merged 2 commits into from Dec 4, 2021

Conversation

nyarly
Copy link
Contributor

@nyarly nyarly commented Dec 3, 2021

Although it isn't yet documented at github, the BranchProtectionRuleEvent
includes an installation field which is crucial for letting Apps reacting to it
to authenticate their requests.

This PR adds that field the event type, along with an accessor for it.

Fixes: #2214.

@google-cla google-cla bot added the cla: no label Dec 3, 2021
@nyarly
Copy link
Contributor Author

nyarly commented Dec 3, 2021

I've just added a CLA for this project.

@gmlewis
Copy link
Collaborator

gmlewis commented Dec 3, 2021

@googlebot rescan

@gmlewis gmlewis changed the title BranchProtectionRuleEvent Installation field Add BranchProtectionRuleEvent Installation field Dec 3, 2021
@gmlewis
Copy link
Collaborator

gmlewis commented Dec 3, 2021

Thank you, @nyarly !
Please run go generate ./... and push (not force-push) the changed files to this PR, and the tests should then pass.
Hopefully @googlebot will also see your signed CLA by then.

@google-cla google-cla bot added cla: yes Indication that the PR author has signed a Google Contributor License Agreement. and removed cla: no labels Dec 3, 2021
@codecov
Copy link

codecov bot commented Dec 4, 2021

Codecov Report

Merging #2216 (2f2e92d) into master (f262aa1) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2216   +/-   ##
=======================================
  Coverage   97.81%   97.81%           
=======================================
  Files         112      112           
  Lines       10117    10117           
=======================================
  Hits         9896     9896           
  Misses        154      154           
  Partials       67       67           
Impacted Files Coverage Δ
github/event_types.go 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f262aa1...2f2e92d. Read the comment docs.

Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @nyarly !
LGTM.

Merging.

@gmlewis gmlewis merged commit b8b15df into google:master Dec 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Indication that the PR author has signed a Google Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Branch Protection Rule Event doesn't serialize installation fields
2 participants