Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add app hook deliveries API #2226

Merged
merged 11 commits into from Dec 16, 2021
Merged

Conversation

pierce-m
Copy link
Contributor

Resolves #2225

@pierce-m
Copy link
Contributor Author

Can we re-run the cla job? I signed it but it hasn't updated 🤔

@gmlewis
Copy link
Collaborator

gmlewis commented Dec 13, 2021

@googlebot - recheck

Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @pierce-m !
Just a few tweaks, please, then we should be ready for a second LGTM before merging.

Also, could you please send a message to @googlebot like "Hey @googlebot - I signed it." and let's see if it responds. Thanks again!

github/apps_hooks_deliveries.go Outdated Show resolved Hide resolved
github/apps_hooks_deliveries.go Outdated Show resolved Hide resolved
github/apps_hooks_deliveries.go Outdated Show resolved Hide resolved
github/apps_hooks_deliveries_test.go Show resolved Hide resolved
@gmlewis gmlewis changed the title App hook deliveries API Add app hook deliveries API Dec 13, 2021
@codecov
Copy link

codecov bot commented Dec 13, 2021

Codecov Report

Merging #2226 (cca80b1) into master (ff33a55) will decrease coverage by 0.02%.
The diff coverage is 92.30%.

❗ Current head cca80b1 differs from pull request most recent head 2aa17ba. Consider uploading reports for the commit 2aa17ba to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2226      +/-   ##
==========================================
- Coverage   97.81%   97.79%   -0.03%     
==========================================
  Files         112      113       +1     
  Lines       10117    10156      +39     
==========================================
+ Hits         9896     9932      +36     
- Misses        154      156       +2     
- Partials       67       68       +1     
Impacted Files Coverage Δ
github/apps_hooks_deliveries.go 92.30% <92.30%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff33a55...2aa17ba. Read the comment docs.

pierce-m and others added 4 commits December 13, 2021 16:26
Co-authored-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
Co-authored-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
Co-authored-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
Co-authored-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
@pierce-m
Copy link
Contributor Author

Looks like it updated with the new commits -- thanks!

Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @pierce-m !
LGTM.

Awaiting second LGTM from any other contributor to this repo before merging.

@pierce-m
Copy link
Contributor Author

@wesleimp can I get some 👀 on this one please?

@gmlewis
Copy link
Collaborator

gmlewis commented Dec 16, 2021

@Parker77 - do you have time to take a look at this one?

Copy link

@Parker77 Parker77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@gmlewis
Copy link
Collaborator

gmlewis commented Dec 16, 2021

LGTM.

Thank you, @Parker77!
Merging.

@gmlewis gmlewis merged commit 1d9884e into google:master Dec 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

List/Get/Redeliver App Webhook Deliveries
3 participants