Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update comment on ListPullRequestsWithCommit API #2228

Merged
merged 1 commit into from Dec 15, 2021

Conversation

mengmichael1
Copy link
Contributor

  1. Correct the statement that results include open and closed PRs by default, when it is only open by default, per

    go-github/github/pulls.go

    Lines 120 to 123 in ff33a55

    type PullRequestListOptions struct {
    // State filters pull requests based on their state. Possible values are:
    // open, closed, all. Default is "open".
    State string `url:"state,omitempty"`

  2. Correct the URL for the Github API doc, per ListPullRequestsWithCommit removed from API docs?  #2227

@codecov
Copy link

codecov bot commented Dec 14, 2021

Codecov Report

Merging #2228 (854edb5) into master (ff33a55) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2228   +/-   ##
=======================================
  Coverage   97.81%   97.81%           
=======================================
  Files         112      112           
  Lines       10117    10117           
=======================================
  Hits         9896     9896           
  Misses        154      154           
  Partials       67       67           
Impacted Files Coverage Δ
github/pulls.go 96.77% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff33a55...854edb5. Read the comment docs.

@mengmichael1
Copy link
Contributor Author

mengmichael1 commented Dec 15, 2021

PTAL @gmlewis, as you pointed me in the right direction for the API docs :) (also saw you helped out with #1186)

Also -- are you a repo manager or can you introduce me to one?

🔁 Repository managers: You can rescan this PR by pressing the "Re-run" button to the left of this description.

I signed the CLA after putting up this PR, so will need a repo manager to re-run the cla/google check for me

@gmlewis
Copy link
Collaborator

gmlewis commented Dec 15, 2021

Yes, I am the primary maintainer of this repo.

Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @mengmichael1 !
LGTM.
Merging.

@gmlewis gmlewis merged commit fef3638 into google:master Dec 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants