Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Changes field to RepositoryEvent #2233

Merged
merged 2 commits into from Dec 16, 2021

Conversation

gmlewis
Copy link
Collaborator

@gmlewis gmlewis commented Dec 15, 2021

Fixes: #2232 .

@gmlewis
Copy link
Collaborator Author

gmlewis commented Dec 15, 2021

@ecrupper - please take a look and let me know what you think.

@codecov
Copy link

codecov bot commented Dec 15, 2021

Codecov Report

Merging #2233 (0f786cc) into master (fef3638) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2233   +/-   ##
=======================================
  Coverage   97.81%   97.81%           
=======================================
  Files         112      112           
  Lines       10117    10117           
=======================================
  Hits         9896     9896           
  Misses        154      154           
  Partials       67       67           
Impacted Files Coverage Δ
github/event_types.go 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fef3638...0f786cc. Read the comment docs.

Copy link
Contributor

@ecrupper ecrupper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pulled this down locally and applied it to my repo rename webhook logic and it worked like a charm! Thanks so much for this!

@gmlewis
Copy link
Collaborator Author

gmlewis commented Dec 15, 2021

Thank you, @ecrupper !

Awaiting second LGTM before merging.
Note that any other repo contributor can review and approve this PR. Thanks!

@gmlewis
Copy link
Collaborator Author

gmlewis commented Dec 16, 2021

Thank you, @pierce-m !
Merging.

@gmlewis gmlewis merged commit 19b1a93 into google:master Dec 16, 2021
@gmlewis gmlewis deleted the issue-2232-repo-change branch December 16, 2021 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add changes to RepositoryEvent
3 participants