Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add PreviousAttemptURL, RunAttempt, RunStartedAt field to WorkflowRun #2238

Merged
merged 1 commit into from Dec 24, 2021
Merged

Add PreviousAttemptURL, RunAttempt, RunStartedAt field to WorkflowRun #2238

merged 1 commit into from Dec 24, 2021

Conversation

tohjustin
Copy link
Contributor

Add PreviousAttemptURL, RunAttempt, RunStartedAt field to the WorkflowRun struct.

Fixes: #2237.

@tohjustin
Add PreviousAttemptURL, RunAttempt, RunStartedAt field to WorkflowRun
fb26aae 
Fixes: google#2237.
Signed-off-by: Justin Toh <tohjustin@hotmail.com>
@codecov
Copy link

codecov bot commented Dec 23, 2021

Codecov Report

Merging #2238 (fb26aae) into master (63a1994) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2238   +/-   ##
=======================================
  Coverage   97.80%   97.80%           
=======================================
  Files         113      113           
  Lines       10205    10205           
=======================================
  Hits         9981     9981           
  Misses        156      156           
  Partials       68       68
Impacted Files Coverage Δ
github/actions_workflow_runs.go 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 63a1994...fb26aae. Read the comment docs.

@tohjustin
Copy link
Contributor Author

I've just signed the CLA, can one of the repository manager trigger a rescan? 😅 Thanks!

gmlewis
gmlewis approved these changes Dec 24, 2021
View reviewed changes
Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @tohjustin !
LGTM.
Merging.

@gmlewis gmlewis merged commit 4d7a0b5 into google:master Dec 24, 2021
@tohjustin
Copy link
Contributor Author

Thanks for reviewing this @gmlewis, happy holidays! 🙏🏼

@tohjustin tohjustin deleted the issue-2237/add-new-fields-to-workflowrun branch December 24, 2021 10:37
@me-diru me-diru mentioned this pull request Dec 24, 2021
Closed
@gmlewis
Copy link
Collaborator

gmlewis commented Dec 25, 2021

Thanks for reviewing this @gmlewis, happy holidays! 🙏🏼

My pleasure! Merry Christmas and Happy Holidays to you too, @tohjustin !

@gmlewis gmlewis mentioned this pull request Jan 13, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmlewis gmlewis gmlewis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add new fields to WorkflowRun
2 participants
@tohjustin @gmlewis