Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add team.html_url #2244

Merged
merged 3 commits into from Dec 30, 2021
Merged

add team.html_url #2244

merged 3 commits into from Dec 30, 2021

Conversation

jplimack
Copy link
Contributor

When performing an edit of a team, the html_url is required invalid: [status.html_url: Required value]

However, that field is missing from the struct, so the previous GET does not marshal this data (even though it is included in the response)

gh api orgs/testing-org/teams/test-secret-team
{
  "name": "test-secret-team",
  "id": 152,
  "node_id": "hmmm==",
  "slug": "test-secret-team",
  "description": "",
  "privacy": "secret",
  "url": "https://github.myorg.com/api/v3/organizations/63/team/152",
  "html_url": "https://github.myorg.com/orgs/testing-org/teams/test-secret-team",
  "members_url": "https://github.myorg.com/api/v3/organizations/63/team/152/members{/member}",
  "repositories_url": "https://github.myorg.com/api/v3/organizations/63/team/152/repos",
}

Signed-off-by: Jake Plimack jplimack@tesla.com

kplimack and others added 2 commits December 30, 2021 11:16
Signed-off-by: Jake Plimack <jplimack@tesla.com>
@gmlewis
Copy link
Collaborator

gmlewis commented Dec 30, 2021

Thank you, @jplimack !
Please run go generate ./... and push the results to the PR, and then tests should pass.
See CONTRIBUTING.md for more info.

Signed-off-by: Jake Plimack <jplimack@tesla.com>
@jplimack
Copy link
Contributor Author

Thanks for your help @gmlewis ! Ive pushed up the generated files

@codecov
Copy link

codecov bot commented Dec 30, 2021

Codecov Report

Merging #2244 (80c6c2f) into master (a899e0f) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2244   +/-   ##
=======================================
  Coverage   97.80%   97.80%           
=======================================
  Files         113      113           
  Lines       10205    10205           
=======================================
  Hits         9981     9981           
  Misses        156      156           
  Partials       68       68           
Impacted Files Coverage Δ
github/teams.go 98.14% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a899e0f...80c6c2f. Read the comment docs.

Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @jplimack !
LGTM.
Merging.

@gmlewis gmlewis merged commit 46ababc into google:master Dec 30, 2021
@gmlewis
Copy link
Collaborator

gmlewis commented May 24, 2022

Fixes: #2088.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants