Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SecretScanningAlertEvent Webhook #2282

Merged
merged 5 commits into from Feb 14, 2022

Conversation

IainSteers
Copy link
Contributor

Fixes #2277

@IainSteers IainSteers changed the title issue 2277 secret scanning alert Add SecretScanningAlertEvent Webhook Feb 4, 2022
@codecov
Copy link

codecov bot commented Feb 4, 2022

Codecov Report

Merging #2282 (1c8a0ca) into master (a842efc) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2282   +/-   ##
=======================================
  Coverage   97.83%   97.83%           
=======================================
  Files         115      115           
  Lines       10360    10362    +2     
=======================================
+ Hits        10136    10138    +2     
  Misses        156      156           
  Partials       68       68           
Impacted Files Coverage Δ
github/event_types.go 100.00% <ø> (ø)
github/messages.go 100.00% <ø> (ø)
github/event.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a842efc...1c8a0ca. Read the comment docs.

@IainSteers
Copy link
Contributor Author

It looks like #2281 introduces the full SecretScanningAlert struct used in the API.

I propose waiting until that merges and then I'll refactor to use it in the webhook payload.

@IainSteers IainSteers force-pushed the issue-2277-secret-scanning-alert branch from a9fdfaa to e73bf7c Compare February 4, 2022 16:23
@IainSteers
Copy link
Contributor Author

@gmlewis this is good to go for review. I rebased it on Friday to use the SecretScanningAlert

Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @IainSteers !
Just a couple minor tweaks, please, for the auto-generated godocs.
Also, please refrain from using force-push in this repo... we squash all commits anyway, and it is easier for the reviewers to see what changed. For more info, please see our CONTRIBUTING.md doc.

github/event_types.go Outdated Show resolved Hide resolved
github/event_types.go Outdated Show resolved Hide resolved
@IainSteers
Copy link
Contributor Author

Apologies for the force-push, did it whilst rebasing without realising. I've made the corrections in punctuation.

Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @IainSteers!
LGTM.

Awaiting second LGTM/Approval from any other contributor of this repo before merging.

Copy link
Contributor

@raynigon raynigon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gmlewis
Copy link
Collaborator

gmlewis commented Feb 14, 2022

Thank you, @raynigon !
Merging.

@gmlewis gmlewis merged commit 41cbf81 into google:master Feb 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support "secret_scanning_alert" webhooks and event payloads
3 participants