-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Add SecretScanningAlertEvent Webhook #2282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SecretScanningAlertEvent Webhook #2282
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2282 +/- ##
=======================================
Coverage 97.83% 97.83%
=======================================
Files 115 115
Lines 10360 10362 +2
=======================================
+ Hits 10136 10138 +2
Misses 156 156
Partials 68 68
Continue to review full report at Codecov.
|
It looks like #2281 introduces the full SecretScanningAlert struct used in the API. I propose waiting until that merges and then I'll refactor to use it in the webhook payload. |
a9fdfaa
to
e73bf7c
Compare
@gmlewis this is good to go for review. I rebased it on Friday to use the SecretScanningAlert |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @IainSteers !
Just a couple minor tweaks, please, for the auto-generated godocs.
Also, please refrain from using force-push in this repo... we squash all commits anyway, and it is easier for the reviewers to see what changed. For more info, please see our CONTRIBUTING.md doc.
Apologies for the force-push, did it whilst rebasing without realising. I've made the corrections in punctuation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @IainSteers!
LGTM.
Awaiting second LGTM/Approval from any other contributor of this repo before merging.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thank you, @raynigon ! |
Fixes #2277