Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub Actions Billing returns total_paid_minutes_used as float64 #2284

Merged
merged 1 commit into from Feb 9, 2022

Conversation

raynigon
Copy link
Contributor

@raynigon raynigon commented Feb 8, 2022

Fixes #2283

GitHub Actions returns total_paid_minutes_used as floating point value.
The Implementation should accept this floating point value as float64.

Example

curl -H "Authorization: Bearer <TOKEN>" \
-H "Accept: application/vnd.github.v3+json"  \
https://api.github.com/orgs/{org}/settings/billing/actions
{
  "total_minutes_used": 1234,
  "total_paid_minutes_used": 3959.0,
  "included_minutes": 3000,
  "minutes_used_breakdown": {
    "UBUNTU": 1234,
    "MACOS": 1234,
    "WINDOWS": 1234
  }
}

GitHub Actions returns total_paid_minutes_used as floating point value.
The Implementation should accept this floating point value as float64.
@gmlewis gmlewis added the Breaking API Change PR will require a bump to the major version num in next release. Look here to see the change(s). label Feb 8, 2022
@codecov
Copy link

codecov bot commented Feb 8, 2022

Codecov Report

Merging #2284 (757e1ce) into master (a842efc) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2284   +/-   ##
=======================================
  Coverage   97.83%   97.83%           
=======================================
  Files         115      115           
  Lines       10360    10360           
=======================================
  Hits        10136    10136           
  Misses        156      156           
  Partials       68       68           
Impacted Files Coverage Δ
github/billing.go 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a842efc...757e1ce. Read the comment docs.

Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @raynigon !
LGTM.

Awaiting second LGTM/Approval from any other contributor to this repo before merging.

@gmlewis
Copy link
Collaborator

gmlewis commented Feb 8, 2022

I'm driving several hundred miles today... I may be slow to respond.

@raynigon
Copy link
Contributor Author

raynigon commented Feb 9, 2022

@Parker77 - do you have time to review this PR?

Copy link

@Parker77 Parker77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gmlewis
Copy link
Collaborator

gmlewis commented Feb 9, 2022

Thank you, @Parker77 !
Merging.

@gmlewis gmlewis merged commit 2be8000 into google:master Feb 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Breaking API Change PR will require a bump to the major version num in next release. Look here to see the change(s).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GitHub Actions Billing returns total_paid_minutes_used as float64
3 participants