Skip to content

Add GetWorkflowRunAttempt #2290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 14, 2022
Merged

Add GetWorkflowRunAttempt #2290

merged 3 commits into from
Feb 14, 2022
+91 −0

Conversation

reeves122
Copy link
Contributor

@reeves122 reeves122 commented Feb 14, 2022 •
edited by gmlewis
Loading

Fixes: #2287

@codecov
Copy link

codecov bot commented Feb 14, 2022 •
edited
Loading

Codecov Report

Merging #2290 (40c8110) into master (2be8000) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2290   +/-   ##
=======================================
  Coverage   97.83%   97.84%           
=======================================
  Files         115      115           
  Lines       10360    10378   +18     
=======================================
+ Hits        10136    10154   +18     
  Misses        156      156           
  Partials       68       68
Impacted Files Coverage Δ
github/actions_workflow_runs.go 100.00% <100.00%> (ø)
github/event.go 100.00% <0.00%> (ø)
github/messages.go 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2be8000...40c8110. Read the comment docs.

gmlewis
gmlewis requested changes Feb 14, 2022
View reviewed changes
Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @reeves122 !
Just one tweak, please.

@gmlewis
Copy link
Collaborator

gmlewis commented Feb 14, 2022

You will now need to run go generate ./... and push the changes to this PR.
See CONTRIBUTING.md for details.

@gmlewis
Copy link
Collaborator

gmlewis commented Feb 14, 2022

Thank you for the review, @jeremiah-norris-champ !

gmlewis
gmlewis approved these changes Feb 14, 2022
View reviewed changes
Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @reeves122 !
LGTM.
Merging.

@gmlewis gmlewis merged commit 2981e4f into google:master Feb 14, 2022
@gmlewis gmlewis mentioned this pull request Mar 2, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmlewis gmlewis

@jeremiah-norris-champ jeremiah-norris-champ

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for getting a workflow run attempt
3 participants
@reeves122 @gmlewis @jeremiah-norris-champ