Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AllowUpdateBranch to the Repository struct #2313

Merged
merged 4 commits into from Mar 15, 2022
Merged

Add AllowUpdateBranch to the Repository struct #2313

merged 4 commits into from Mar 15, 2022

Conversation

MarkRosemaker
Copy link
Contributor

I noticed that I can edit all the settings for a repository via the API except the setting:

Always suggest updating pull request branches
Whenever there are new changes available in the base branch, present an “update branch” option in the pull request.

This PR aims to change that. I verified the changed code by making an edit request to one of my repositories.

This PR will solve #2312.

@google-cla
Copy link

google-cla bot commented Mar 5, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

For more information, open the CLA check for this pull request.

@gmlewis
Copy link
Collaborator

gmlewis commented Mar 5, 2022

Thank you, @MarkRosemaker !
Instead of editing the auto-generated files manually, please run go generate ./... and push (not force-push) the commit to this PR. This should fix the broken tests. Please see CONTRIBUTING.md for more information.

@MarkRosemaker
Copy link
Contributor Author

Thank you, @MarkRosemaker ! Instead of editing the auto-generated files manually, please run go generate ./... and push (not force-push) the commit to this PR. This should fix the broken tests. Please see CONTRIBUTING.md for more information.

Thank you for the suggestion, @gmlewis ! Done. :)

@codecov
Copy link

codecov bot commented Mar 15, 2022

Codecov Report

Merging #2313 (ecb6ec9) into master (4d609bd) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2313   +/-   ##
=======================================
  Coverage   97.84%   97.84%           
=======================================
  Files         115      115           
  Lines       10415    10416    +1     
=======================================
+ Hits        10191    10192    +1     
  Misses        156      156           
  Partials       68       68           
Impacted Files Coverage Δ
github/repos.go 98.70% <100.00%> (+<0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4d609bd...ecb6ec9. Read the comment docs.

Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @MarkRosemaker !
LGTM.
Merging.

@gmlewis gmlewis changed the title Add AllowUpdateBranch to the Repository definition Add AllowUpdateBranch to the Repository struct Mar 15, 2022
@gmlewis gmlewis merged commit f859098 into google:master Mar 15, 2022
@MarkRosemaker MarkRosemaker deleted the add-AllowUpdateBranch-to-repository-definition branch March 16, 2022 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants