-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Clean up method return consistency #2318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up method return consistency #2318
Conversation
According to https://githubstatus.com , actions are currently experiencing degraded performance, which is why no tests have run as of yet. |
Codecov Report
@@ Coverage Diff @@
## master #2318 +/- ##
==========================================
+ Coverage 97.95% 98.04% +0.09%
==========================================
Files 117 117
Lines 10402 10460 +58
==========================================
+ Hits 10189 10256 +67
+ Misses 146 140 -6
+ Partials 67 64 -3
Continue to review full report at Codecov.
|
@Parker77 - do you have time for a code review? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Thank you, @Parker77 ! |
@h2floh pointed out in #2315 that our method returns are inconsistent.
This PR addresses this inconsistency.
@h2floh - please review and LGTM+Approve this PR if you agree to the changes.