Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve stringify test coverage #2320

Merged
merged 2 commits into from Mar 25, 2022
Merged

Conversation

gmlewis
Copy link
Collaborator

@gmlewis gmlewis commented Mar 25, 2022

This PR adds missing structs and slices to the stringify tests for better test coverage.

@codecov
Copy link

codecov bot commented Mar 25, 2022

Codecov Report

Merging #2320 (c235e4a) into master (6cd5d41) will increase coverage by 0.05%.
The diff coverage is n/a.

❗ Current head c235e4a differs from pull request most recent head 1bb88f3. Consider uploading reports for the commit 1bb88f3 to get more accurate results

@@            Coverage Diff             @@
##           master    #2320      +/-   ##
==========================================
+ Coverage   97.87%   97.92%   +0.05%     
==========================================
  Files         117      115       -2     
  Lines       10402    10416      +14     
==========================================
+ Hits        10181    10200      +19     
+ Misses        154      148       -6     
- Partials       67       68       +1     
Impacted Files Coverage Δ
github/repos_contents.go 88.95% <0.00%> (-0.38%) ⬇️
github/github.go 97.64% <0.00%> (-0.10%) ⬇️
github/actions_artifacts.go 100.00% <0.00%> (ø)
github/actions_workflow_jobs.go 100.00% <0.00%> (ø)
github/actions_workflow_runs.go 100.00% <0.00%> (ø)
github/repos_actions_permissions.go
github/repos_actions_allowed.go
github/repos.go 98.70% <0.00%> (+0.04%) ⬆️
github/repos_stats.go 95.34% <0.00%> (+2.32%) ⬆️
github/misc.go 100.00% <0.00%> (+3.63%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6cd5d41...1bb88f3. Read the comment docs.

@gmlewis
Copy link
Collaborator Author

gmlewis commented Mar 25, 2022

@Parker77 - do you have time for a code review?

Copy link

@Parker77 Parker77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gmlewis
Copy link
Collaborator Author

gmlewis commented Mar 25, 2022

Thank you, @Parker77 !
Merging.

@gmlewis gmlewis merged commit 1694b79 into google:master Mar 25, 2022
@gmlewis gmlewis deleted the stringify-tests branch March 25, 2022 02:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants