Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove code duplication #2321

Merged
merged 3 commits into from Mar 25, 2022
Merged

Conversation

gmlewis
Copy link
Collaborator

@gmlewis gmlewis commented Mar 25, 2022

This PR removes code duplication as detected by golangci-lint.

@gmlewis
Copy link
Collaborator Author

gmlewis commented Mar 25, 2022

@Parker77 - do you have time for a code review?

@codecov
Copy link

codecov bot commented Mar 25, 2022

Codecov Report

Merging #2321 (714e01a) into master (631fa70) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #2321      +/-   ##
==========================================
+ Coverage   97.84%   97.86%   +0.01%     
==========================================
  Files         115      115              
  Lines       10416    10352      -64     
==========================================
- Hits        10192    10131      -61     
+ Misses        156      154       -2     
+ Partials       68       67       -1     
Impacted Files Coverage Δ
github/actions_artifacts.go 100.00% <100.00%> (ø)
github/actions_workflow_jobs.go 100.00% <100.00%> (ø)
github/actions_workflow_runs.go 100.00% <100.00%> (ø)
github/github.go 97.73% <100.00%> (+0.09%) ⬆️
github/repos.go 98.66% <100.00%> (-0.05%) ⬇️
github/repos_contents.go 89.33% <100.00%> (+0.37%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 631fa70...714e01a. Read the comment docs.

Copy link

@Parker77 Parker77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gmlewis
Copy link
Collaborator Author

gmlewis commented Mar 25, 2022

Thank you, @Parker77 !
Merging.

@gmlewis gmlewis merged commit 6cd5d41 into google:master Mar 25, 2022
@gmlewis gmlewis deleted the remove-code-duplication branch March 25, 2022 02:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants