Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update workflow to use Go 1.18 and Go 1.17 #2322

Merged
merged 1 commit into from Apr 3, 2022
Merged

Update workflow to use Go 1.18 and Go 1.17 #2322

merged 1 commit into from Apr 3, 2022

Conversation

gmlewis
Copy link
Collaborator

@gmlewis gmlewis commented Mar 25, 2022

No description provided.

@codecov
Copy link

codecov bot commented Mar 25, 2022

Codecov Report

Merging #2322 (2844dcb) into master (3e8a7f0) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2322   +/-   ##
=======================================
  Coverage   98.04%   98.04%           
=======================================
  Files         117      117           
  Lines       10460    10460           
=======================================
  Hits        10256    10256           
  Misses        140      140           
  Partials       64       64

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e8a7f0...2844dcb. Read the comment docs.

@gmlewis
Copy link
Collaborator Author

gmlewis commented Mar 25, 2022

Awaiting LGTM+Approval from any contributor on this repo before merging.

@gmlewis gmlewis added the NeedsReview PR is awaiting a review before merging. label Mar 25, 2022
raynigon
raynigon approved these changes Apr 3, 2022
View reviewed changes
Copy link
Contributor

@raynigon raynigon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gmlewis
Copy link
Collaborator Author

gmlewis commented Apr 3, 2022

Thank you, @raynigon !
Merging.

@gmlewis gmlewis merged commit f9762eb into google:master Apr 3, 2022
@gmlewis gmlewis deleted the update-go118 branch April 3, 2022 16:43
@gmlewis gmlewis removed the NeedsReview PR is awaiting a review before merging. label Apr 30, 2022
@gmlewis gmlewis mentioned this pull request Apr 30, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raynigon raynigon raynigon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gmlewis @raynigon