Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for the pull request review thread event #2326

Conversation

taisph
Copy link
Contributor

@taisph taisph commented Mar 30, 2022

Fixes #2324

github/pulls_threads.go Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Mar 30, 2022

Codecov Report

Merging #2326 (0f34008) into master (c28ccfd) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #2326   +/-   ##
=======================================
  Coverage   98.04%   98.04%           
=======================================
  Files         117      118    +1     
  Lines       10454    10458    +4     
=======================================
+ Hits        10250    10254    +4     
  Misses        140      140           
  Partials       64       64           
Impacted Files Coverage Δ
github/event_types.go 100.00% <ø> (ø)
github/messages.go 100.00% <ø> (ø)
github/event.go 100.00% <100.00%> (ø)
github/pulls_threads.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c28ccfd...0f34008. Read the comment docs.

@taisph taisph force-pushed the feature/gh2324-webhook-event-type-pull_request_review_thread-missing branch from 0a0b536 to 0f34008 Compare March 30, 2022 21:06
@taisph
Copy link
Contributor Author

taisph commented Mar 30, 2022

I added the link https://docs.github.com/en/developers/webhooks-and-events/webhook-events-and-payloads#pull_request_review_thread which presumably will be the correct link once they update the docs by looking at the existing structure. I don't know what to expect with regards to when they'll update it as I managed to find a misnamed issue about the missing documentation that was created back in November 2021.

Should this PR be kept back until the docs are updated?

@gmlewis
Copy link
Collaborator

gmlewis commented Mar 30, 2022

Should this PR be kept back until the docs are updated?

I don't think that's necessary. Many endpoints have been added in the past just based on observing the response received, so I think this is fine. It can always be updated once the official docs are released. Thank you, @taisph !

@taisph taisph marked this pull request as ready for review March 30, 2022 21:30
@taisph taisph requested a review from gmlewis March 31, 2022 18:11
Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @taisph !
LGTM.

Awaiting second LGTM+Approval from any other contributor to this repo before merging.

@gmlewis gmlewis added the NeedsReview PR is awaiting a review before merging. label Apr 1, 2022
Copy link
Contributor

@raynigon raynigon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gmlewis
Copy link
Collaborator

gmlewis commented Apr 3, 2022

Thank you, @raynigon !
Merging.

@gmlewis gmlewis merged commit 1df4afd into google:master Apr 3, 2022
@taisph taisph deleted the feature/gh2324-webhook-event-type-pull_request_review_thread-missing branch April 4, 2022 07:54
@gmlewis gmlewis removed the NeedsReview PR is awaiting a review before merging. label Apr 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Webhook event type pull_request_review_thread missing
3 participants