-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Add support for the pull request review thread event #2326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for the pull request review thread event #2326
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2326 +/- ##
=======================================
Coverage 98.04% 98.04%
=======================================
Files 117 118 +1
Lines 10454 10458 +4
=======================================
+ Hits 10250 10254 +4
Misses 140 140
Partials 64 64
Continue to review full report at Codecov.
|
0a0b536
to
0f34008
Compare
I added the link https://docs.github.com/en/developers/webhooks-and-events/webhook-events-and-payloads#pull_request_review_thread which presumably will be the correct link once they update the docs by looking at the existing structure. I don't know what to expect with regards to when they'll update it as I managed to find a misnamed issue about the missing documentation that was created back in November 2021. Should this PR be kept back until the docs are updated? |
I don't think that's necessary. Many endpoints have been added in the past just based on observing the response received, so I think this is fine. It can always be updated once the official docs are released. Thank you, @taisph ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @taisph !
LGTM.
Awaiting second LGTM+Approval from any other contributor to this repo before merging.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thank you, @raynigon ! |
Fixes #2324