-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Add support to sync a fork branch with the upstream repository. #2337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support to sync a fork branch with the upstream repository. #2337
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2337 +/- ##
=======================================
Coverage 98.04% 98.05%
=======================================
Files 118 118
Lines 10458 10470 +12
=======================================
+ Hits 10254 10266 +12
Misses 140 140
Partials 64 64
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @lkxed !
This is looking great, but instead of creating two new files, would you mind adding your code to the existing repos_merging.go
and repos_merging_test.go
files?
I think both are small enough and related enough to live in the same file.
Hi, @gmlewis . I have moved my code. :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @lkxed !
Just one minor renaming tweak, please, then I think we will be ready for a second LGTM before merging.
@gmlewis I have changed the names. :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @lkxed !
LGTM.
Awaiting second LGTM+Approval from any other contributor to this repo before merging.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thank you, @raynigon ! |
Resolved #2335
Thanks for this opportunity.