Add fields to RateLimits struct

[shokada]

Fixes: #2339

What this PR does / why we need it:

I added fields to RateLimits struct to get rate limits other than core and search

Special notes for your reviewer:

Since there is no documentation for source_import, code_scanning_upload, actions_runner_registration, and scim, I did not know which endpoints had the rate limit set, so I did not fix category function.

go-github/github/github.go

Lines 1126 to 1134 in 942d33d

	// category returns the rate limit category of the endpoint, determined by Request.URL.Path.
	func category(path string) rateLimitCategory {
	switch {
	default:
	return coreCategory
	case strings.HasPrefix(path, "/search/"):
	return searchCategory
	}
	}

[google-cla]

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

For more information, open the CLA check for this pull request.

[shokada]

There seems to be no document for source_import, code_scanning_upload, actions_runner_registration, scim.

[gmlewis]

Thank you, @shokada!
Let's tweak some of the acronym names, please.
Then we should be ready for a second LGTM+Approval before merging.

[gmlewis]

Also please remember to run gofmt on your edited files and go generate ./... , then push (not force-push) the changed files to the PR.

[shokada]

Run go generate ./... 5887f39

[codecov]

Codecov Report

Merging #2340 (a6c7bcd) into master (00e4233) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #2340   +/-   ##
=======================================
  Coverage   98.04%   98.05%           
=======================================
  Files         118      118           
  Lines       10458    10476   +18     
=======================================
+ Hits        10254    10272   +18     
  Misses        140      140           
  Partials       64       64           

Impacted Files	Coverage Δ
github/github.go	97.80% <100.00%> (+0.06%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 00e4233...a6c7bcd. Read the comment docs.

[shokada]

Since TestClient_rateLimits does not pass, I have defined unused constants.

[gmlewis]

Instead of doing this, we actually need to use these values in the category function (lines 1127-1134 below) and in the RateLimits method (lines 1154-1163 below).

[shokada]

in the RateLimits method (lines 1154-1163 below).

fixed a6c7bcd

in the category function (lines 1127-1134 below)

I could not figure out how to fix the category function for the following reasons...

Since there is no documentation for source_import, code_scanning_upload, actions_runner_registration, and scim, I did not know which endpoints had the rate limit set, so I did not fix category function.
#2340 (comment)

[gmlewis]

Instead of doing this, we actually need to use these values in the category function (lines 1127-1134 below) and in the RateLimits method (lines 1154-1163 below).

[gmlewis]

Thank you, @shokada !
LGTM.

Awaiting second LGTM+Approval from any other contributor to this repo before merging.

[raynigon]

LGTM

[gmlewis]

LGTM

Thank you, @raynigon !
Merging.

[patrickmarabeas]

@gmlewis is it possible to get a fresh release pushed out? Thanks!

[gmlewis]

Yes, I can work on one tomorrow.

[gmlewis]

@gmlewis is it possible to get a fresh release pushed out? Thanks!

@patrickmarabeas - v45 has now been released: https://github.com/google/go-github/releases/tag/v45.0.0