Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ReRequestCheckRun #2358

Merged
merged 4 commits into from May 16, 2022
Merged

Conversation

leonpham0
Copy link
Contributor

@google-cla
Copy link

google-cla bot commented May 4, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

For more information, open the CLA check for this pull request.

@codecov
Copy link

codecov bot commented May 4, 2022

Codecov Report

Merging #2358 (6c6aab9) into master (4174796) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #2358   +/-   ##
=======================================
  Coverage   98.05%   98.05%           
=======================================
  Files         119      119           
  Lines       10487    10497   +10     
=======================================
+ Hits        10283    10293   +10     
  Misses        140      140           
  Partials       64       64           
Impacted Files Coverage Δ
github/checks.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4174796...6c6aab9. Read the comment docs.

@gmlewis gmlewis changed the title Rerequest Check Run Add ReRequestCheckRun May 4, 2022
Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @leonpham0 !
Just one minor tweak, please, then we should be ready for a second LGTM+Approval before merging.

github/checks.go Outdated Show resolved Hide resolved
@gmlewis gmlewis added the NeedsReview PR is awaiting a review before merging. label May 4, 2022
leonpham0 and others added 2 commits May 4, 2022 14:56
Co-authored-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
@leonpham0 leonpham0 requested a review from gmlewis May 4, 2022 21:59
Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @leonpham0 !
LGTM.

Awaiting second LGTM+Approval from any other contributor to this repo before merging.

Copy link
Contributor

@raynigon raynigon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gmlewis gmlewis removed the NeedsReview PR is awaiting a review before merging. label May 16, 2022
@gmlewis
Copy link
Collaborator

gmlewis commented May 16, 2022

LGTM

Thank you, @raynigon !
Merging.

@gmlewis gmlewis merged commit ce36651 into google:master May 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants