Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'repository_import' event #2364

Merged
merged 2 commits into from May 16, 2022

Conversation

ldez
Copy link
Contributor

@ldez ldez commented May 14, 2022

@codecov
Copy link

codecov bot commented May 14, 2022

Codecov Report

Merging #2364 (3d7a799) into master (8947206) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #2364   +/-   ##
=======================================
  Coverage   98.05%   98.05%           
=======================================
  Files         119      119           
  Lines       10503    10505    +2     
=======================================
+ Hits        10299    10301    +2     
  Misses        140      140           
  Partials       64       64           
Impacted Files Coverage Δ
github/messages.go 100.00% <ø> (ø)
github/event.go 100.00% <100.00%> (ø)
github/event_types.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8947206...3d7a799. Read the comment docs.

Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @ldez !
One minor tweak, please, then we should be ready for a second LGTM+Approval from any other contributor to the repo before merging.

github/event_types.go Show resolved Hide resolved
@gmlewis gmlewis added the NeedsReview PR is awaiting a review before merging. label May 14, 2022
Co-authored-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @ldez ! Wow, that was fast! 😄

Awaiting second LGTM+Approval from any other contributor to the repo before merging.

Copy link
Contributor

@raynigon raynigon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gmlewis
Copy link
Collaborator

gmlewis commented May 16, 2022

LGTM

Thank you, @raynigon !
Merging.

@gmlewis gmlewis removed the NeedsReview PR is awaiting a review before merging. label May 16, 2022
@gmlewis gmlewis merged commit 15b20d3 into google:master May 16, 2022
@ldez ldez deleted the feat/add-repository_import-event branch May 16, 2022 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants