Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TextMatch custom header to other search type custom headers #2388

Merged
merged 2 commits into from Aug 13, 2022

Conversation

DarkMatterV
Copy link
Contributor

@DarkMatterV DarkMatterV commented Jun 17, 2022

Fix TextMatch Option doesn't work when search type is commits topics repositories or issues (#2385)

Fixes: #2385.

@google-cla
Copy link

google-cla bot commented Jun 17, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@codecov
Copy link

codecov bot commented Jun 17, 2022

Codecov Report

Merging #2388 (398d048) into master (697804f) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #2388   +/-   ##
=======================================
  Coverage   98.06%   98.06%           
=======================================
  Files         119      119           
  Lines       10545    10548    +3     
=======================================
+ Hits        10341    10344    +3     
  Misses        140      140           
  Partials       64       64           
Impacted Files Coverage Δ
github/search.go 93.61% <100.00%> (+0.13%) ⬆️
github/repos.go 98.66% <0.00%> (+<0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 697804f...398d048. Read the comment docs.

Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @DarkMatterV !
Please make sure to run the modified files through gofmt.
See CONTRIBUTING.md for more details.

github/search.go Show resolved Hide resolved
@gmlewis gmlewis changed the title Fix TextMatch Option doesn't work when search type is commits topics repositories or issues Add TextMatch custom header to other search type custom headers Jun 20, 2022
Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @DarkMatterV !
LGTM.

Awaiting second LGTM from any other contributor to this repo before merging.

@gmlewis gmlewis added the NeedsReview PR is awaiting a review before merging. label Jun 20, 2022
Copy link
Contributor

@raynigon raynigon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gmlewis
Copy link
Collaborator

gmlewis commented Aug 13, 2022

Thank you, @raynigon !
Merging.

@gmlewis gmlewis merged commit 744a645 into google:master Aug 13, 2022
@gmlewis gmlewis removed the NeedsReview PR is awaiting a review before merging. label Aug 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TextMatch doesn't work when use Search.Repositories
3 participants