Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MembersCanForkPrivateRepositories field to Organization struct #2389

Merged
merged 2 commits into from Jun 20, 2022

Conversation

lmt-swallow
Copy link
Contributor

@lmt-swallow lmt-swallow commented Jun 18, 2022

This PR adds MembersCanForkPrivateRepositories field to Organization struct.

Signed-off-by: Takashi Yoneuchi <takashi.yoneuchi@shift-js.info>
@google-cla
Copy link

google-cla bot commented Jun 18, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@codecov
Copy link

codecov bot commented Jun 18, 2022

Codecov Report

Merging #2389 (b510ad5) into master (697804f) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2389   +/-   ##
=======================================
  Coverage   98.06%   98.06%           
=======================================
  Files         119      119           
  Lines       10545    10546    +1     
=======================================
+ Hits        10341    10342    +1     
  Misses        140      140           
  Partials       64       64           
Impacted Files Coverage Δ
github/orgs.go 96.90% <ø> (ø)
github/repos.go 98.66% <0.00%> (+<0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 697804f...b510ad5. Read the comment docs.

Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @lmt-swallow!
Let's please shorten the field name like it's neighbors.

github/orgs.go Outdated Show resolved Hide resolved
…nForkPrivateRepos`

Signed-off-by: Takashi Yoneuchi <takashi.yoneuchi@shift-js.info>
@lmt-swallow lmt-swallow requested a review from gmlewis June 20, 2022 09:54
Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @lmt-swallow !
LGTM.
Merging.

@gmlewis gmlewis merged commit 8309da1 into google:master Jun 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants