Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

code_scanning_alert missing in eventTypeMapping #2391

Closed
emilva opened this issue Jun 21, 2022 · 4 comments · Fixed by #2392
Closed

code_scanning_alert missing in eventTypeMapping #2391

emilva opened this issue Jun 21, 2022 · 4 comments · Fixed by #2392
Assignees
@emilva

Comments

@emilva
Copy link
Contributor

emilva commented Jun 21, 2022

Hi team,

I am using github.com/google/go-github/v45 v45.1.0 and I am getting the error =unknown X-Github-Event in message: code_scanning_alert when running ParseWebHook.

The alert type was already added in #2311 so I think it is just a matter of adding the mapping to the parsing of the webhook.

Cheers,

emil
@gmlewis
Copy link
Collaborator

gmlewis commented Jun 21, 2022

Ah, yes, thank you, @emilva !
Would you like to submit a PR to rectify this, or shall I open it up to the rest of the contributors to this repo?

@emilva
Copy link
Contributor Author

emilva commented Jun 21, 2022

Yes, I will try to open PR shortly!

@gmlewis
Copy link
Collaborator

gmlewis commented Jun 21, 2022

Yes, I will try to open PR shortly!

Thank you, @emilva ! It's yours. 😄

@emilva emilva mentioned this issue Jun 21, 2022
Merged
@emilva
Copy link
Contributor Author

emilva commented Jun 21, 2022

PR: #2392

gmlewis pushed a commit that referenced this issue Aug 13, 2022
@emilva
Add support for parsing code_scanning_alerts in webhooks (#2392)
388289c 
Fixes: #2391.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@emilva emilva

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add support for parsing code_scanning_alerts in webhooks emilva/go-github
2 participants
@emilva @gmlewis