Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for parsing code_scanning_alerts in webhooks #2392

Merged
merged 1 commit into from Aug 13, 2022
Merged

Add support for parsing code_scanning_alerts in webhooks #2392

merged 1 commit into from Aug 13, 2022

Conversation

emilva
Copy link
Contributor

@emilva emilva commented Jun 21, 2022 •
edited by gmlewis

Following up on the issue I created #2391.

Let me know if there is anything missing or needs fixing. I just tried to follow the patterns from the other types.

Cheers,

emil

Fixes: #2391.

@emilva emilva mentioned this pull request Jun 21, 2022
Closed
gmlewis
gmlewis approved these changes Jun 21, 2022
View reviewed changes
Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @emilva !
LGTM.

Awaiting second LGTM from any other contributor to this repo before merging.

@gmlewis gmlewis added the NeedsReview PR is awaiting a review before merging. label Jun 21, 2022
@codecov
Copy link

codecov bot commented Jun 21, 2022

Codecov Report

Merging #2392 (1f8d04e) into master (8309da1) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #2392   +/-   ##
=======================================
  Coverage   98.06%   98.06%           
=======================================
  Files         119      119           
  Lines       10546    10548    +2     
=======================================
+ Hits        10342    10344    +2     
  Misses        140      140           
  Partials       64       64
Impacted Files Coverage Δ
github/messages.go 100.00% <ø> (ø)
github/event.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8309da1...1f8d04e. Read the comment docs.

@emilva
Copy link
Contributor Author

emilva commented Jun 21, 2022

Thanks @gmlewis! :D

raynigon
raynigon approved these changes Aug 13, 2022
View reviewed changes
Copy link
Contributor

@raynigon raynigon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gmlewis
Copy link
Collaborator

gmlewis commented Aug 13, 2022

Thank you, @raynigon !
Merging.

@gmlewis gmlewis merged commit 388289c into google:master Aug 13, 2022
@emilva emilva deleted the code-scanning-alert-event-webhook branch August 15, 2022 16:17
@gmlewis gmlewis removed the NeedsReview PR is awaiting a review before merging. label Aug 19, 2022
@gmlewis gmlewis mentioned this pull request Aug 19, 2022
Merged
@lukehinds lukehinds mentioned this pull request Jun 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmlewis gmlewis gmlewis approved these changes

@raynigon raynigon raynigon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

code_scanning_alert missing in eventTypeMapping
3 participants
@emilva @gmlewis @raynigon