Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tag protection #2424

Merged
merged 5 commits into from Aug 13, 2022
Merged

Add tag protection #2424

merged 5 commits into from Aug 13, 2022

Conversation

jfengupgrade
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Jul 28, 2022

Codecov Report

Merging #2424 (d7f3036) into master (3a432d6) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #2424   +/-   ##
=======================================
  Coverage   98.06%   98.07%           
=======================================
  Files         120      121    +1     
  Lines       10558    10591   +33     
=======================================
+ Hits        10354    10387   +33     
  Misses        140      140           
  Partials       64       64           
Impacted Files Coverage Δ
github/repos_tags.go 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us.

Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @jfengupgrade !
Just a few tweaks, please.

example/tagprotection/main.go Outdated Show resolved Hide resolved
example/tagprotection/main.go Outdated Show resolved Hide resolved
example/tagprotection/main.go Outdated Show resolved Hide resolved
example/tagprotection/main.go Outdated Show resolved Hide resolved
example/tagprotection/main.go Outdated Show resolved Hide resolved
example/tagprotection/main.go Outdated Show resolved Hide resolved
example/tagprotection/main.go Outdated Show resolved Hide resolved
github/repos_tags.go Outdated Show resolved Hide resolved
github/repos_tags.go Outdated Show resolved Hide resolved
github/repos_tags.go Outdated Show resolved Hide resolved
@gmlewis gmlewis added the NeedsReview PR is awaiting a review before merging. label Jul 28, 2022
Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @jfengupgrade !
LGTM.

Awaiting second LGTM from any other contributor to this repo before merging.

@jfengupgrade
Copy link
Contributor Author

@gmlewis Thanks a lot for the reviewing

Copy link
Contributor

@raynigon raynigon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gmlewis
Copy link
Collaborator

gmlewis commented Aug 13, 2022

Thank you, @raynigon !
Merging.

@gmlewis gmlewis merged commit aa96e8d into google:master Aug 13, 2022
@gmlewis gmlewis removed the NeedsReview PR is awaiting a review before merging. label Aug 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants