Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add BypassPullRequestAllowances field #2432

Merged
merged 6 commits into from Aug 13, 2022

Conversation

Starttoaster
Copy link
Contributor

Closes #2431

@codecov
Copy link

codecov bot commented Aug 4, 2022

Codecov Report

Merging #2432 (27efd09) into master (aff6c4b) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2432   +/-   ##
=======================================
  Coverage   98.06%   98.06%           
=======================================
  Files         120      120           
  Lines       10558    10558           
=======================================
  Hits        10354    10354           
  Misses        140      140           
  Partials       64       64           
Impacted Files Coverage Δ
github/repos.go 98.66% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @Starttoaster !
Just a few minor changes, please.

github/repos.go Outdated Show resolved Hide resolved
github/repos.go Outdated Show resolved Hide resolved
github/repos.go Outdated Show resolved Hide resolved
github/repos.go Outdated Show resolved Hide resolved
github/repos.go Outdated Show resolved Hide resolved
github/repos.go Outdated Show resolved Hide resolved
github/repos.go Outdated Show resolved Hide resolved
@gmlewis gmlewis added the NeedsReview PR is awaiting a review before merging. label Aug 4, 2022
Co-authored-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
@Starttoaster
Copy link
Contributor Author

Thanks for the review @gmlewis ! Committed all suggestions.

Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @Starttoaster !
LGTM.

Awaiting second LGTM from any other contributor to this repo before merging.

@Starttoaster
Copy link
Contributor Author

Thank you, @Starttoaster ! LGTM.

Awaiting second LGTM from any other contributor to this repo before merging.

Thanks!

@gmlewis
Copy link
Collaborator

gmlewis commented Aug 4, 2022

Whups, I jumped the gun... it looks like some of your contributed files need to be run through gofmt, please.

@Starttoaster
Copy link
Contributor Author

Whups, I jumped the gun... it looks like some of your contributed files need to be run through gofmt, please.

Weird. Usually my text editor fmts for me, I guess it didn't because of the length of the file. Thanks!

@Starttoaster
Copy link
Contributor Author

@gmlewis pardon me if this comes off as hasty, I just kind of want to switch my go.mods off of my fork, and open up this PR to see if it's merged once a day or so. I was curious what the usual expectation is for duration of time between first and second tier of PR reviews? Not trying to put pressure, I just want to set my expectations accordingly.

@gmlewis
Copy link
Collaborator

gmlewis commented Aug 7, 2022

@gmlewis pardon me if this comes off as hasty, I just kind of want to switch my go.mods off of my fork, and open up this PR to see if it's merged once a day or so. I was curious what the usual expectation is for duration of time between first and second tier of PR reviews? Not trying to put pressure, I just want to set my expectations accordingly.

Hi @Starttoaster - this repo is maintained by volunteers and we rely on other contributors to the repo to perform second code reviews when appropriate. Sometimes it is immediate, but more often it takes days or weeks. There are a few people that I can reach out to when there is some kind of urgency, but I prefer to not bother them unless there is. However, let's see if anyone steps up by tomorrow and if not, I can request that one of these trustworthy individuals take a look if they have time.

Thank you for your patience.

@Starttoaster
Copy link
Contributor Author

It's not urgent or anything. No need to disrupt people. I can just keep my go.mods pinned to my fork for eternity if need be, it's just not really my preference is all. I was mostly just interested to hear how this process is intended to go. I enjoy the idea of community PR reviews, but in practice, it's been my observation that it's not usually a great experience for would-be contributors awaiting reviewers because most devs put their focus on their day jobs and then log out at the end of the day to spend time with their families (understandably, because that's how they make money to live.)

Anyway, tl;dr -- no need to move mountains for me. Just wanted to set my expectations correctly so I wouldn't feel compelled to load this PR page every morning.

Copy link
Contributor

@raynigon raynigon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gmlewis
Copy link
Collaborator

gmlewis commented Aug 13, 2022

Thank you, @raynigon !
Merging.

@gmlewis gmlewis merged commit 6212c67 into google:master Aug 13, 2022
@gmlewis gmlewis removed the NeedsReview PR is awaiting a review before merging. label Aug 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Additional options available for pull request reviews / branch protection rules
3 participants