Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add parameters to configure merge commit messages to repo #2440

Merged
merged 2 commits into from Aug 21, 2022

Conversation

garrettheel
Copy link
Contributor

These new parameters have been added to the repository api to allow more granular control of merge commit messages:

  • squash_merge_commit_title
  • squash_merge_commit_message
  • merge_commit_title
  • merge_commit_message

@codecov
Copy link

codecov bot commented Aug 20, 2022

Codecov Report

Merging #2440 (0fe7b9f) into master (2eccd8c) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #2440   +/-   ##
=======================================
  Coverage   98.08%   98.08%           
=======================================
  Files         122      122           
  Lines       10632    10636    +4     
=======================================
+ Hits        10428    10432    +4     
  Misses        140      140           
  Partials       64       64           
Impacted Files Coverage Δ
github/repos.go 98.67% <100.00%> (+<0.01%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @garrettheel !
LGTM.
Merging.

@gmlewis
Copy link
Collaborator

gmlewis commented Aug 20, 2022

Looking at the linked docs, these 4 new fields have a small number of allowed values...
I think it might be beneficial to include them as comments, such as:

// SquashMergeCommitTitle can be one of: "PR_TITLE", "COMMIT_OR_PR_TITLE"

Thoughts?

@garrettheel
Copy link
Contributor Author

Looking at the linked docs, these 4 new fields have a small number of allowed values... I think it might be beneficial to include them as comments

@gmlewis yep, that makes sense! I wasn't sure how much we wanted to re-document the API here, but I think this would help quickly figure out valid inputs. Pushed up another commit with comments, let me know if that's the right spot for them

@gmlewis gmlewis merged commit 01c8feb into google:master Aug 21, 2022
@garrettheel garrettheel deleted the add-merge-commit-params-to-repo branch August 22, 2022 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants