-
Notifications
You must be signed in to change notification settings - Fork 2.1k
List Secret Scan Alerts with index based pagination #2446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
List Secret Scan Alerts with index based pagination #2446
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2446 +/- ##
=======================================
Coverage 98.03% 98.03%
=======================================
Files 122 122
Lines 10690 10690
=======================================
Hits 10480 10480
Misses 144 144
Partials 66 66
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Thank you, @AbbanMustafa - were you ever able to test this successfully? |
Yes! I verified works for both list option types |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please add a unit test demonstrating how/where/why this is being used?
@AbbanMustafa - it looks like some unit tests broke - could you please fix them? Also make sure your code is formatted... I haven't taken a look yet... just reporting the breakage. |
Co-authored-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @AbbanMustafa !
LGTM.
Merging.
No description provided.