-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Return proper responses for SCIM provisioned identities #2474
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Codecov Report
@@ Coverage Diff @@
## master #2474 +/- ##
=======================================
Coverage 98.03% 98.03%
=======================================
Files 122 122
Lines 10695 10705 +10
=======================================
+ Hits 10485 10495 +10
Misses 144 144
Partials 66 66
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @tenyo !
Just a couple minor nits, please, and then we should be ready for a second LGTM+Approval from any other contributor to this repo.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @tenyo !
LGTM.
Awaiting second LGTM+Approval from any other contributor to this repo before merging.
Thank you, @wesleimp ! |
This PR adds return responses to
ListSCIMProvisionedIdentities
andGetSCIMProvisioningInfoForUser
, as before it was not possible to get the output of those calls.Fixes #2338