Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return proper responses for SCIM provisioned identities #2474

Merged
merged 4 commits into from Sep 27, 2022

Conversation

tenyo
Copy link
Contributor

@tenyo tenyo commented Sep 21, 2022

This PR adds return responses to ListSCIMProvisionedIdentities and GetSCIMProvisioningInfoForUser, as before it was not possible to get the output of those calls.
Fixes #2338

@google-cla
Copy link

google-cla bot commented Sep 21, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@codecov
Copy link

codecov bot commented Sep 21, 2022

Codecov Report

Merging #2474 (ce48d9d) into master (8a4bdb5) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #2474   +/-   ##
=======================================
  Coverage   98.03%   98.03%           
=======================================
  Files         122      122           
  Lines       10695    10705   +10     
=======================================
+ Hits        10485    10495   +10     
  Misses        144      144           
  Partials       66       66           
Impacted Files Coverage Δ
github/scim.go 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @tenyo !
Just a couple minor nits, please, and then we should be ready for a second LGTM+Approval from any other contributor to this repo.

github/scim.go Show resolved Hide resolved
github/scim.go Show resolved Hide resolved
@gmlewis gmlewis added Breaking API Change PR will require a bump to the major version num in next release. Look here to see the change(s). NeedsReview PR is awaiting a review before merging. labels Sep 21, 2022
@tenyo tenyo requested a review from gmlewis September 21, 2022 22:15
Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @tenyo !
LGTM.

Awaiting second LGTM+Approval from any other contributor to this repo before merging.

@gmlewis
Copy link
Collaborator

gmlewis commented Sep 27, 2022

Thank you, @wesleimp !
Merging.

@gmlewis gmlewis merged commit 0c3cd12 into google:master Sep 27, 2022
@gmlewis gmlewis removed the NeedsReview PR is awaiting a review before merging. label Sep 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Breaking API Change PR will require a bump to the major version num in next release. Look here to see the change(s).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How are you supposed to access the output of ListSCIMProvisionedIdentities?
3 participants