Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RepositoryCreateForkOptions is should be body parameters #2489

Closed
valbeat opened this issue Oct 11, 2022 · 2 comments · Fixed by #2490
Closed

RepositoryCreateForkOptions is should be body parameters #2489

valbeat opened this issue Oct 11, 2022 · 2 comments · Fixed by #2490
Assignees
@valbeat

Comments

@valbeat
Copy link
Contributor

valbeat commented Oct 11, 2022

Hi Team!
RepositoryCreateForkOptions is not working. because it is not url params but body params.
docs.github.com/en/rest/repos/forks#create-a-fork

Sorry I didn't realize this when I added it before.

I will create a pull request for this issue.
Thanks.
@valbeat valbeat mentioned this issue Oct 11, 2022
Merged
@TruRelax
Copy link

TruRelax commented Dec 1, 2022

@valbeat Any progress on this issue?

@valbeat
Copy link
Contributor Author

valbeat commented Dec 2, 2022

@TruRelax it is awaiting review. could you review this one? #2490

gmlewis pushed a commit that referenced this issue Dec 9, 2022
@valbeat
Change create fork options from url param to body param (#2490)
3e3f03c 
Fixes: #2489.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@valbeat valbeat

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Change create fork options from url param to body param valbeat/go-github
2 participants
@valbeat @TruRelax