Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix use GITHUB_OUTPUT from deprecated set-output #2492

Merged
merged 11 commits into from Oct 12, 2022

Conversation

k1rnt
Copy link
Contributor

@k1rnt k1rnt commented Oct 12, 2022

resolved #2491

@google-cla
Copy link

google-cla bot commented Oct 12, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @k1rnt !
Just a couple minor tweaks, please.

.github/workflows/tests.yml Outdated Show resolved Hide resolved
.github/workflows/tests.yml Outdated Show resolved Hide resolved
k1rnt and others added 2 commits October 12, 2022 23:00
Co-authored-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
Co-authored-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
@k1rnt
Copy link
Contributor Author

k1rnt commented Oct 12, 2022

Sorry.
Thanks for noticing all the details!

@codecov
Copy link

codecov bot commented Oct 12, 2022

Codecov Report

Merging #2492 (7c3ba78) into master (10f65ab) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2492   +/-   ##
=======================================
  Coverage   97.99%   97.99%           
=======================================
  Files         123      123           
  Lines       10762    10762           
=======================================
  Hits        10546    10546           
  Misses        148      148           
  Partials       68       68           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@gmlewis
Copy link
Collaborator

gmlewis commented Oct 12, 2022

Hmmm... I'm not sure why the tests are failing... it looks like this change is not working properly. The error message is:

Error: Path Validation Error: At least one directory or file path is required

ksnip_20221012-101850

Can you please investigate, @k1rnt and see if you can find out what is going on?

@k1rnt
Copy link
Contributor Author

k1rnt commented Oct 12, 2022

😖
Just found it myself too.
Might not know the immediate cause, but I'll investigate and see!
@gmlewis Thanks for the report!

@k1rnt
Copy link
Contributor Author

k1rnt commented Oct 12, 2022

@gmlewis
It appears that Shell needed to be specified correctly.
I've PASSED all the TESTs, so please re-review!

@k1rnt k1rnt requested a review from gmlewis October 12, 2022 16:52
@gmlewis
Copy link
Collaborator

gmlewis commented Oct 12, 2022

@gmlewis It appears that Shell needed to be specified correctly. I've PASSED all the TESTs, so please re-review!

Wheh! Thank you for your persistence, @k1rnt ! It is greatly appreciated!
❤️

@gmlewis gmlewis merged commit 3344412 into google:master Oct 12, 2022
@k1rnt k1rnt deleted the fix/gha-set-output-command branch October 12, 2022 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix set-output in Github Actions to be deprecated
2 participants