Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create custom role APIs #2494

Merged
merged 5 commits into from Oct 17, 2022
Merged

Create custom role APIs #2494

merged 5 commits into from Oct 17, 2022

Conversation

mohaldu
Copy link
Contributor

@mohaldu mohaldu commented Oct 14, 2022

resolves #2493

@google-cla
Copy link

google-cla bot commented Oct 14, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@mohaldu mohaldu force-pushed the custom-role-api branch 2 times, most recently from 5e8c0d0 to 3d4fccb Compare October 14, 2022 09:33
@gmlewis
Copy link
Collaborator

gmlewis commented Oct 15, 2022

Hi @mohaldu - please don't use force-push in this repo... we always squash-and-merge anyway, so it is not necessary. See CONTRIBUTING.md for more details.

Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @mohaldu!
Just a few changes, please, then we should be ready for a second review before merging.

github/orgs_custom_roles.go Outdated Show resolved Hide resolved
github/orgs_custom_roles.go Outdated Show resolved Hide resolved
github/orgs_custom_roles.go Outdated Show resolved Hide resolved
github/orgs_custom_roles.go Outdated Show resolved Hide resolved
github/orgs_custom_roles.go Outdated Show resolved Hide resolved
github/orgs_custom_roles.go Outdated Show resolved Hide resolved
github/orgs_custom_roles.go Outdated Show resolved Hide resolved
github/orgs_custom_roles.go Outdated Show resolved Hide resolved
github/orgs_custom_roles.go Outdated Show resolved Hide resolved
github/orgs_custom_roles.go Outdated Show resolved Hide resolved
@gmlewis gmlewis added the NeedsReview PR is awaiting a review before merging. label Oct 15, 2022
@mohaldu
Copy link
Contributor Author

mohaldu commented Oct 16, 2022

Hi @gmlewis thanks for the review, all changes made

@mohaldu mohaldu requested a review from gmlewis October 16, 2022 05:24
@gmlewis
Copy link
Collaborator

gmlewis commented Oct 16, 2022

@mohaldu - please run go generate ./... at the top of the repo then push the resulting changes.
See CONTRIBUTING.md for more details.

Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @mohaldu !
LGTM.

Awaiting second LGTM+Approval from any other contributor to this repo before merging.

@codecov
Copy link

codecov bot commented Oct 17, 2022

Codecov Report

Merging #2494 (621667b) into master (38d7b16) will decrease coverage by 0.02%.
The diff coverage is 92.30%.

@@            Coverage Diff             @@
##           master    #2494      +/-   ##
==========================================
- Coverage   97.99%   97.97%   -0.03%     
==========================================
  Files         123      123              
  Lines       10774    10813      +39     
==========================================
+ Hits        10558    10594      +36     
- Misses        148      150       +2     
- Partials       68       69       +1     
Impacted Files Coverage Δ
github/orgs_custom_roles.go 94.23% <92.30%> (-5.77%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@valbeat valbeat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mohaldu LGTM!

@gmlewis
Copy link
Collaborator

gmlewis commented Oct 17, 2022

Thank you, @valbeat !
Merging.

@gmlewis gmlewis removed the NeedsReview PR is awaiting a review before merging. label Oct 17, 2022
@gmlewis gmlewis merged commit 861fd9a into google:master Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support to create / update / delete custom roles for organisations
3 participants