Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add enterprise list runner applications download #2496

Merged

Conversation

gabriel-samfira
Copy link
Contributor

@gabriel-samfira gabriel-samfira commented Oct 14, 2022

This change adds ListRunnerApplicationDownloads() to the Enterprise service.

Fixes: #2495

Signed-off-by: Gabriel Adrian Samfira gsamfira@cloudbasesolutions.com

This change adds ListRunnerApplicationDownloads() to the Enterprise
service.

Signed-off-by: Gabriel Adrian Samfira <gsamfira@cloudbasesolutions.com>
@codecov
Copy link

codecov bot commented Oct 14, 2022

Codecov Report

Merging #2496 (c555ecc) into master (3344412) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #2496   +/-   ##
=======================================
  Coverage   97.99%   97.99%           
=======================================
  Files         123      123           
  Lines       10762    10774   +12     
=======================================
+ Hits        10546    10558   +12     
  Misses        148      148           
  Partials       68       68           
Impacted Files Coverage Δ
github/enterprise_actions_runners.go 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@gmlewis gmlewis added the NeedsReview PR is awaiting a review before merging. label Oct 15, 2022
Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @gabriel-samfira !
LGTM.

Awaiting second LGTM+Approval from any other contributor to this repo before merging.

Copy link
Contributor

@valbeat valbeat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gmlewis
Copy link
Collaborator

gmlewis commented Oct 16, 2022

Thank you, @valbeat !
Merging.

@gmlewis gmlewis removed the NeedsReview PR is awaiting a review before merging. label Oct 16, 2022
@gmlewis gmlewis merged commit 38d7b16 into google:master Oct 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing ListRunnerApplicationDownloads() for Enterprise
3 participants