Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test cases for JSON resource marshaling #2520

Merged
merged 10 commits into from Oct 26, 2022

Conversation

Harikesh00
Copy link
Contributor

Added test cases for DispatchRequestOptions, TransferRequest, SignaturesProtectedBranch, DismissalRestrictionsRequest of file github/repos.go

contribution to #55

@gmlewis gmlewis changed the title Added test cases for JSON resource marshaling Add test cases for JSON resource marshaling Oct 25, 2022
Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @Harikesh00 !

github/repos_test.go Outdated Show resolved Hide resolved
@gmlewis
Copy link
Collaborator

gmlewis commented Oct 25, 2022

@Harikesh00 - do you want Hacktoberfest credit for this one? If so, please add to the description in future PRs. Thank you!

@Harikesh00
Copy link
Contributor Author

yes @gmlewis. I want this for Hacktoberfest, kindly add the label for same

@codecov
Copy link

codecov bot commented Oct 25, 2022

Codecov Report

Merging #2520 (bb208c1) into master (9b60dfb) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2520   +/-   ##
=======================================
  Coverage   97.97%   97.97%           
=======================================
  Files         123      123           
  Lines       10813    10813           
=======================================
  Hits        10594    10594           
  Misses        150      150           
  Partials       69       69           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just for consistency sake, could you please add in the whitespace to all the want strings that the standard Go json.MarshalIndent would add so that all our JSON examples look the same?

@Harikesh00
Copy link
Contributor Author

spaces added
plz check

Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @Harikesh00 !
LGTM.
Merging.

@gmlewis gmlewis merged commit f9d2c6b into google:master Oct 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants