-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Add test cases for JSON resource marshaling #2520
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @Harikesh00 !
@Harikesh00 - do you want Hacktoberfest credit for this one? If so, please add to the description in future PRs. Thank you! |
yes @gmlewis. I want this for Hacktoberfest, kindly add the label for same |
Codecov Report
@@ Coverage Diff @@
## master #2520 +/- ##
=======================================
Coverage 97.97% 97.97%
=======================================
Files 123 123
Lines 10813 10813
=======================================
Hits 10594 10594
Misses 150 150
Partials 69 69 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just for consistency sake, could you please add in the whitespace to all the want
strings that the standard Go json.MarshalIndent
would add so that all our JSON examples look the same?
…into repos-test-marshal
…into repos-test-marshal
…into repos-test-marshal
…into repos-test-marshal
…into repos-test-marshal
spaces added |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @Harikesh00 !
LGTM.
Merging.
Added test cases for
DispatchRequestOptions
,TransferRequest
,SignaturesProtectedBranch
,DismissalRestrictionsRequest
of filegithub/repos.go
contribution to #55