Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test case for JSON resource marshaling #2545

Merged
merged 3 commits into from Oct 29, 2022

Conversation

rahulkarmore
Copy link
Contributor

Hi creator,
Added test cases for JSON Resources :
SearchResult
Helps: #55

I have followed all the guidelines to contribute to this repository.
Please revert in case of any changes are needed.
I am a first-time contributor to Hackoctober, It will be a great help if u can encourage me & accept my contribution.

@codecov
Copy link

codecov bot commented Oct 29, 2022

Codecov Report

Merging #2545 (1c93976) into master (9473fc9) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2545   +/-   ##
=======================================
  Coverage   97.97%   97.97%           
=======================================
  Files         123      123           
  Lines       10813    10813           
=======================================
  Hits        10594    10594           
  Misses        150      150           
  Partials       69       69           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

github/search_test.go Outdated Show resolved Hide resolved
Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @rahulkarmore .
LGTM.
Merging.

No more PRs will be accepted for Hacktoberfest credit due to me being OOO. See #55.

@gmlewis gmlewis merged commit 43edea6 into google:master Oct 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants