Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test cases for JSON resource marshaling #2548

Merged
merged 1 commit into from Oct 31, 2022

Conversation

vaibhavgholap23
Copy link
Contributor

Hi creators,
I have added test case for :
HovercardOptions struct
under Helps:#55 issue

I have followed all the guidelines to contribute in this repository.
Please revert in case of any changes needed.
I am first time contributor of Hackoctober , It will be great if you review & accept my contribution.

@codecov
Copy link

codecov bot commented Oct 31, 2022

Codecov Report

Merging #2548 (6823d5e) into master (330d92d) will decrease coverage by 0.06%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2548      +/-   ##
==========================================
- Coverage   98.03%   97.97%   -0.07%     
==========================================
  Files         122      123       +1     
  Lines       10705    10813     +108     
==========================================
+ Hits        10495    10594      +99     
- Misses        144      150       +6     
- Partials       66       69       +3     
Impacted Files Coverage Δ
github/orgs_custom_roles.go 94.23% <0.00%> (-5.77%) ⬇️
github/repos.go 98.67% <0.00%> (ø)
github/enterprise_actions_runners.go 100.00% <0.00%> (ø)
github/users_ssh_signing_keys.go 89.47% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@vaibhavgholap23
Copy link
Contributor Author

Hi creators, I have added test case for : HovercardOptions struct under Helps:#55 issue

I have followed all the guidelines to contribute in this repository. Please revert in case of any changes needed. I am first time contributor of Hackoctober , It will be great if you review & accept my contribution.

@vaibhavgholap23
Copy link
Contributor Author

@andygrunwald pls accept my PR for Hackoctober fest contribution.

@andygrunwald
Copy link
Contributor

@vaibhavgholap23 Not sure how I can help here.
I am not part of the maintainer team.

Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gmlewis gmlewis merged commit 5d388bd into google:master Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants