Support users and teams in branch protection access restrictions #2561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2561 +/- ##
==========================================
+ Coverage 98.03% 98.05% +0.01%
==========================================
Files 130 130
Lines 11144 11242 +98
==========================================
+ Hits 10925 11023 +98
Misses 150 150
Partials 69 69
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
gmlewis
requested changes
Nov 7, 2022
|
Hi @gmlewis! Sorry but it wasn't until now when I had time to come back to this issue. 😞 I've addressed your review changes plus went through some other endpoints to make sure they comply with official docs naming. |
|
Should be good to go now! 🚀 |
gmlewis
approved these changes
Jan 16, 2023
There was a problem hiding this comment.
Thank you, @jporzucek !
LGTM.
Awaiting second LGTM+Approval from any other contributor to this repo before merging.
|
Thank you, @valbeat ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2560
It also adds a ListAppRestrictions wrapper around ListApp so naming conventions with ListUserRestrictions and ListTeamRestrictions methods is preserved.