Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new field for issue state reason #2583

Merged

Conversation

ganeshkumarsv
Copy link
Contributor

@ganeshkumarsv ganeshkumarsv commented Nov 29, 2022

Adds new field state_reason for GitHub Issue struct.
reference on the field: https://docs.github.com/en/rest/issues/issues?apiVersion=2022-11-28#update-an-issue

@codecov
Copy link

codecov bot commented Nov 29, 2022

Codecov Report

Merging #2583 (d8540d1) into master (18cd63d) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2583   +/-   ##
=======================================
  Coverage   97.98%   97.98%           
=======================================
  Files         125      125           
  Lines       10875    10875           
=======================================
  Hits        10656    10656           
  Misses        150      150           
  Partials       69       69           
Impacted Files Coverage Δ
github/issues.go 97.41% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@gmlewis gmlewis changed the title Issue: Add new field for issue state reason Add new field for issue state reason Nov 29, 2022
Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @ganeshkumarsv !
I think a comment here might be useful, if you don't mind.

github/issues.go Show resolved Hide resolved
Co-authored-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
@ganeshkumarsv
Copy link
Contributor Author

Thanks for the suggestion @gmlewis! I committed your suggestion

@ganeshkumarsv
Copy link
Contributor Author

@gmlewis once the PR gets approved and merged, can we have a new release?

@gmlewis
Copy link
Collaborator

gmlewis commented Nov 29, 2022

@gmlewis once the PR gets approved and merged, can we have a new release?

I would really like to get #2581 in before releasing v48.2.0. Hopefully that can happen today.

Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @ganeshkumarsv !
LGTM.
Merging.

@gmlewis gmlewis merged commit 6c430ac into google:master Nov 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants