Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable secret scanning with the enterprise-level REST API #2607

Merged
merged 10 commits into from Dec 26, 2022

Conversation

VenuManikanta
Copy link
Contributor

@VenuManikanta VenuManikanta commented Dec 25, 2022

This branch adds support for

GitHub Changelog: Enable secret scanning with the enterprise-level REST API

Resolves #2599
Blog
Documentation

@google-cla
Copy link

google-cla bot commented Dec 25, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@codecov
Copy link

codecov bot commented Dec 25, 2022

Codecov Report

Merging #2607 (e21b6c3) into master (84cc7d5) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #2607   +/-   ##
=======================================
  Coverage   97.99%   97.99%           
=======================================
  Files         126      127    +1     
  Lines       10913    10948   +35     
=======================================
+ Hits        10694    10729   +35     
  Misses        150      150           
  Partials       69       69           
Impacted Files Coverage Δ
github/enterprise_code_security_and_analysis.go 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @VenuManikanta !

github/enterprise_code_security_and_analysis.go Outdated Show resolved Hide resolved
github/enterprise_code_security_and_analysis.go Outdated Show resolved Hide resolved
github/enterprise_code_security_and_analysis.go Outdated Show resolved Hide resolved
github/enterprise_code_security_and_analysis.go Outdated Show resolved Hide resolved
github/enterprise_code_security_and_analysis.go Outdated Show resolved Hide resolved
github/enterprise_code_security_and_analysis.go Outdated Show resolved Hide resolved
github/enterprise_code_security_and_analysis_test.go Outdated Show resolved Hide resolved
@gmlewis gmlewis added the NeedsReview PR is awaiting a review before merging. label Dec 26, 2022
Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @VenuManikanta !
After a couple minor tweaks, we should be ready for a second LGTM+Approval from any other contributor to this repo before merging.

github/enterprise_code_security_and_analysis.go Outdated Show resolved Hide resolved
@VenuManikanta
Copy link
Contributor Author

Hi @gmlewis
Can you tag another contributor for approval?

@gmlewis
Copy link
Collaborator

gmlewis commented Dec 26, 2022

Hi @gmlewis Can you tag another contributor for approval?

We try not to do that as much as possible in this repo, since everyone supporting this repo is doing so on a voluntary basis.
But we'll see what we can do.

Co-authored-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @VenuManikanta !
LGTM.

@Parker77 - I hate to bother you, but do you have time today for a code review?

Copy link

@Parker77 Parker77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gmlewis gmlewis removed the NeedsReview PR is awaiting a review before merging. label Dec 26, 2022
@gmlewis
Copy link
Collaborator

gmlewis commented Dec 26, 2022

Thank you, @Parker77 !
Merging.

@gmlewis gmlewis merged commit 4a5aa8c into google:master Dec 26, 2022
@VenuManikanta
Copy link
Contributor Author

VenuManikanta commented Dec 27, 2022

Thanks @gmlewis and @Parker77
For responding even during holidays :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable secret scanning with the enterprise-level REST API
3 participants