-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Omit OpenID Connect customization template claims when none are set #2620
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Omit OpenID Connect customization template claims when none are set #2620
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2620 +/- ##
=======================================
Coverage 98.01% 98.02%
=======================================
Files 128 129 +1
Lines 11055 11084 +29
=======================================
+ Hits 10836 10865 +29
Misses 150 150
Partials 69 69
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @F21 !
One minor tweak, please, then we will be ready for a second LGTM+Approval from any other contributor to this repo before merging.
Thanks for the quick review @gmlewis ! Pushed another commit to remove the blank line. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @F21 ! (for future PRs, there's no need to force-push in this repo since we always squash-and-merge at the end anyway, just FYI... no biggie.)
LGTM.
Awaiting second LGTM+Approval from any other contributor to this repo before merging.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Thank you, @valbeat ! |
There's a bug in the OpenID Connect customization template in #2615 where
included_claim_keys
is set tonil
and sent to the GitHub API if it is not set. This results in the API returning a422 Unprocessable Entity
error.This PR resolves this by setting the JSON annotation of
IncludeClaimKeys
inOIDCSubjectClaimCustomTemplate
toomitempty
and adds a test to verify this.